Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pkg/analysis_server/test/operation/operation_queue_test.dart

Issue 869153003: Prioritize analysis operations for contexts with priority files. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/mocks.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/operation/operation_queue_test.dart
diff --git a/pkg/analysis_server/test/operation/operation_queue_test.dart b/pkg/analysis_server/test/operation/operation_queue_test.dart
index 1ef1ce55a499dea356ad399b591acd922a28c85f..0a4f13e4903867b5d6ac9be0c5cbce10f9d82605 100644
--- a/pkg/analysis_server/test/operation/operation_queue_test.dart
+++ b/pkg/analysis_server/test/operation/operation_queue_test.dart
@@ -11,6 +11,8 @@ import 'package:analysis_server/src/operation/operation_queue.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:typed_mock/typed_mock.dart';
import 'package:unittest/unittest.dart';
+import '../mocks.dart';
+import 'package:analyzer/src/generated/source.dart';
main() {
groupSep = ' | ';
@@ -68,10 +70,8 @@ main() {
test('continue analysis first', () {
var analysisContext = new AnalysisContextMock();
- var operationA =
- new PerformAnalysisOperation(analysisContext, false, false);
- var operationB =
- new PerformAnalysisOperation(analysisContext, false, true);
+ var operationA = new PerformAnalysisOperation(analysisContext, false);
+ var operationB = new PerformAnalysisOperation(analysisContext, true);
queue.add(operationA);
queue.add(operationB);
expect(queue.take(), operationB);
@@ -80,14 +80,31 @@ main() {
});
test('priority context first', () {
+ var prioritySource = new MockSource();
var analysisContextA = new AnalysisContextMock();
var analysisContextB = new AnalysisContextMock();
- var operationA =
- new PerformAnalysisOperation(analysisContextA, false, false);
- var operationB =
- new PerformAnalysisOperation(analysisContextB, true, false);
+ analysisContextB.prioritySources = [prioritySource];
+ var operationA = new PerformAnalysisOperation(analysisContextA, false);
+ var operationB = new PerformAnalysisOperation(analysisContextB, false);
+ queue.add(operationA);
+ queue.add(operationB);
+ expect(queue.take(), operationB);
+ expect(queue.take(), operationA);
+ expect(queue.take(), isNull);
+ });
+
+ test('reschedule', () {
+ var prioritySource = new MockSource();
+ var analysisContextA = new AnalysisContextMock();
+ var analysisContextB = new AnalysisContextMock();
+ var operationA = new PerformAnalysisOperation(analysisContextA, false);
+ var operationB = new PerformAnalysisOperation(analysisContextB, false);
queue.add(operationA);
queue.add(operationB);
+ // update priority sources and reschedule
+ analysisContextB.prioritySources = [prioritySource];
+ queue.reschedule();
+ // verify order
expect(queue.take(), operationB);
expect(queue.take(), operationA);
expect(queue.take(), isNull);
@@ -107,7 +124,9 @@ ServerOperation mockOperation(ServerOperationPriority priority) {
}
-class AnalysisContextMock extends TypedMock implements AnalysisContext {
+class AnalysisContextMock extends TypedMock implements InternalAnalysisContext {
+ List<Source> prioritySources = <Source>[];
+
noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
}
« no previous file with comments | « pkg/analysis_server/test/mocks.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698