Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 869153003: Prioritize analysis operations for contexts with priority files. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index dddadf69335c839238494f7e92e714faa081c423..f47c1d37036093e6775c57c952ceb3945e43beb6 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -110,14 +110,13 @@ class PerformAnalysisOperation extends ServerOperation {
static const int WORKING_CACHE_SIZE = 512;
final AnalysisContext context;
- final bool isPriority;
final bool isContinue;
- PerformAnalysisOperation(this.context, this.isPriority, this.isContinue);
+ PerformAnalysisOperation(this.context, this.isContinue);
@override
ServerOperationPriority get priority {
- if (isPriority) {
+ if (_isPriorityContext) {
if (isContinue) {
return ServerOperationPriority.PRIORITY_ANALYSIS_CONTINUE;
} else {
@@ -132,6 +131,10 @@ class PerformAnalysisOperation extends ServerOperation {
}
}
+ bool get _isPriorityContext =>
+ context is InternalAnalysisContext &&
+ (context as InternalAnalysisContext).prioritySources.isNotEmpty;
+
@override
void perform(AnalysisServer server) {
//
@@ -159,8 +162,7 @@ class PerformAnalysisOperation extends ServerOperation {
_sendNotices(server, notices);
_updateIndex(server, notices);
// continue analysis
- server.addOperation(
- new PerformAnalysisOperation(context, isPriority, true));
+ server.addOperation(new PerformAnalysisOperation(context, true));
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/operation/operation_queue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698