Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: remoting/protocol/pairing_registry.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/authenticator_test_base.cc ('k') | remoting/protocol/v2_authenticator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/pairing_registry.cc
diff --git a/remoting/protocol/pairing_registry.cc b/remoting/protocol/pairing_registry.cc
index c159ce6c56e960807317304b62def4a7e9b3d090..f1ce333cf67b3c9a84514edbd8839f1d8b697854 100644
--- a/remoting/protocol/pairing_registry.cc
+++ b/remoting/protocol/pairing_registry.cc
@@ -49,10 +49,8 @@ PairingRegistry::Pairing PairingRegistry::Pairing::Create(
std::string shared_secret;
char buffer[kKeySize];
crypto::RandBytes(buffer, arraysize(buffer));
- if (!base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
- &shared_secret)) {
- LOG(FATAL) << "Base64Encode failed.";
- }
+ base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),
+ &shared_secret);
return Pairing(created_time, client_name, client_id, shared_secret);
}
« no previous file with comments | « remoting/protocol/authenticator_test_base.cc ('k') | remoting/protocol/v2_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698