Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: net/test/spawned_test_server/base_test_server.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_sspi_win.cc ('k') | net/third_party/mozilla_security_manager/nsKeygenHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/spawned_test_server/base_test_server.cc
diff --git a/net/test/spawned_test_server/base_test_server.cc b/net/test/spawned_test_server/base_test_server.cc
index 775341b608e6bd93ffe56712b1a676a3477b9bc5..7ef2abaf1d177a3106199e357888bc5fd8f406fa 100644
--- a/net/test/spawned_test_server/base_test_server.cc
+++ b/net/test/spawned_test_server/base_test_server.cc
@@ -226,10 +226,8 @@ bool BaseTestServer::GetFilePathWithReplacements(
const std::string& new_text = it->second;
std::string base64_old;
std::string base64_new;
- if (!base::Base64Encode(old_text, &base64_old))
- return false;
- if (!base::Base64Encode(new_text, &base64_new))
- return false;
+ base::Base64Encode(old_text, &base64_old);
+ base::Base64Encode(new_text, &base64_new);
if (first_query_parameter) {
new_file_path += "?";
first_query_parameter = false;
@@ -400,8 +398,7 @@ bool BaseTestServer::GenerateArguments(base::DictionaryValue* arguments) const {
}
if (!ssl_options_.signed_cert_timestamps.empty()) {
std::string b64_scts;
- if (!base::Base64Encode(ssl_options_.signed_cert_timestamps, &b64_scts))
- return false;
+ base::Base64Encode(ssl_options_.signed_cert_timestamps, &b64_scts);
arguments->SetString("signed-cert-timestamps", b64_scts);
}
}
« no previous file with comments | « net/http/http_auth_sspi_win.cc ('k') | net/third_party/mozilla_security_manager/nsKeygenHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698