sync/protocol/proto_value_conversions.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index 0217c5c0076e71dc1853b31340f138e910cdb83c..cdb999ea0dd873c1fed6ad65bbe2f270e07c7481 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -54,9 +54,7 @@ base::StringValue* MakeInt64Value(int64 x) {

// that instead of a StringValue.

base::StringValue* MakeBytesValue(const std::string& bytes) {

std::string bytes_base64;

- if (!base::Base64Encode(bytes, &bytes_base64)) {

- NOTREACHED();

- }

+ base::Base64Encode(bytes, &bytes_base64);

return new base::StringValue(bytes_base64);

}