remoting/protocol/authenticator_test_base.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/authenticator_test_base.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/authenticator_test_base.cc

diff --git a/remoting/protocol/authenticator_test_base.cc b/remoting/protocol/authenticator_test_base.cc

index 8311476e612c4eb5d6d721b2127c67ae78e9e6ec..25b0efecb80d4deeee21dc93502b3e023e89ab6b 100644

--- a/remoting/protocol/authenticator_test_base.cc

+++ b/remoting/protocol/authenticator_test_base.cc

@@ -53,7 +53,7 @@ void AuthenticatorTestBase::SetUp() {

std::string key_string;

ASSERT_TRUE(base::ReadFileToString(key_path, &key_string));

std::string key_base64;

- ASSERT_TRUE(base::Base64Encode(key_string, &key_base64));

+ base::Base64Encode(key_string, &key_base64);

key_pair_ = RsaKeyPair::FromString(key_base64);

ASSERT_TRUE(key_pair_.get());

host_public_key_ = key_pair_->GetPublicKey();