net/http/http_auth_gssapi_posix.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_gssapi_posix.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_gssapi_posix.cc

diff --git a/net/http/http_auth_gssapi_posix.cc b/net/http/http_auth_gssapi_posix.cc

index 4ea4bb9c343612e38e0f6f4cec42fa51628191ef..41cbcdbcdc005a24597fcd8d03b6209b884ee869 100644

--- a/net/http/http_auth_gssapi_posix.cc

+++ b/net/http/http_auth_gssapi_posix.cc

@@ -734,11 +734,7 @@ int HttpAuthGSSAPI::GenerateAuthToken(const AuthCredentials* credentials,

std::string encode_input(static_cast<char*>(output_token.value),

output_token.length);

std::string encode_output;

- bool base64_rv = base::Base64Encode(encode_input, &encode_output);

- if (!base64_rv) {

- LOG(ERROR) << "Base64 encoding of auth token failed.";

- return ERR_ENCODING_CONVERSION_FAILED;

- }

+ base::Base64Encode(encode_input, &encode_output);

*auth_token = scheme_ + " " + encode_output;

return OK;

}