chrome/test/chromedriver/chrome_launcher.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome_launcher.cc

diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc

index ce8fa18d44528dd4afa36650f1bb3ed789ad2427..da598f64f3f454bf17cf57b2e63cf173c0f2cf16 100644

--- a/chrome/test/chromedriver/chrome_launcher.cc

+++ b/chrome/test/chromedriver/chrome_launcher.cc

@@ -497,8 +497,7 @@ Status ProcessExtension(const std::string& extension,

if (key_len != public_key.size())

return Status(kUnknownError, "invalid public key length");

std::string public_key_base64;

- if (!base::Base64Encode(public_key, &public_key_base64))

- return Status(kUnknownError, "cannot base64 encode public key");

+ base::Base64Encode(public_key, &public_key_base64);

std::string id = GenerateExtensionId(public_key);

// Unzip the crx file.