chrome/browser/extensions/api/identity/web_auth_flow.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/web_auth_flow.cc

diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.cc b/chrome/browser/extensions/api/identity/web_auth_flow.cc

index eb6106857521331fa196c6dca32a6be74615b590..220e983ab3fa40dd35d201d031957479c1c2897a 100644

--- a/chrome/browser/extensions/api/identity/web_auth_flow.cc

+++ b/chrome/browser/extensions/api/identity/web_auth_flow.cc

@@ -76,8 +76,7 @@ void WebAuthFlow::Start() {

// in OnShellWindowAdded.

std::string random_bytes;

crypto::RandBytes(WriteInto(&random_bytes, 33), 32);

- bool success = base::Base64Encode(random_bytes, &shell_window_key_);

- DCHECK(success);

+ base::Base64Encode(random_bytes, &shell_window_key_);

// identityPrivate.onWebFlowRequest(shell_window_key, provider_url_, mode_)

scoped_ptr<base::ListValue> args(new base::ListValue());