Issue 869103003: Set correct try server project for chromium try bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 869103003: Set correct try server project for chromium try bots. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
Sergiy Byelozyorov

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Set correct try server project for chromium try bots. TBR=sergiyb@chromium.org

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	codereview.settings	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sergiy Byelozyorov

lgtm https://codereview.chromium.org/869103003/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/869103003/diff/1/codereview.settings#newcode9 codereview.settings:9: PROJECT: v8 I wonder where is this used?

5 years, 11 months ago (2015-01-23 11:45:16 UTC) #3

Michael Achenbach

No idea. So: patch_project is correct in this job: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_rel_ng/builds/9 project is chrome - but ...

5 years, 11 months ago (2015-01-23 11:46:45 UTC) #4

Sergiy Byelozyorov

5 years, 11 months ago (2015-01-26 16:12:04 UTC) #5

https://codereview.chromium.org/869103003/diff/1/codereview.settings
File codereview.settings (right):

https://codereview.chromium.org/869103003/diff/1/codereview.settings#newcode9
codereview.settings:9: PROJECT: v8
On 2015/01/23 11:45:16, Sergiy Byelozyorov wrote:
> I wonder where is this used?

We've discussed it offline. It is used by 'git cl upload' to set a project on
Rietveld, which in turn passes it to build as 'patch_project' property.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages