Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 869083004: [Android] Revised initial commit of the HttpTestServer. (abandoned) (Closed)

Created:
5 years, 10 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Revised initial commit of the HttpTestServer. This still contains only the DefaultResponseHandler. BUG=448626

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 10 months ago (2015-02-10 19:11:25 UTC) #2
jbudorick
+rsleevi I'm not sure if you're the right person to review this (after phajdan, who ...
5 years, 10 months ago (2015-02-11 16:43:48 UTC) #4
Ryan Sleevi
You picked the right person, but I'm trying to push people in the exact opposite ...
5 years, 10 months ago (2015-02-11 16:48:09 UTC) #5
jbudorick
On 2015/02/11 16:48:09, Ryan Sleevi wrote: > You picked the right person, but I'm trying ...
5 years, 10 months ago (2015-02-11 16:54:33 UTC) #6
Ryan Sleevi
5 years, 10 months ago (2015-02-11 17:04:28 UTC) #7
On 2015/02/11 16:54:33, jbudorick wrote:
> On 2015/02/11 16:48:09, Ryan Sleevi wrote:
> > You picked the right person, but I'm trying to push people in the exact
> opposite
> > of this direction (see
> > https://code.google.com/p/chromium/issues/detail?id=456210 )
> > 
> > We should chat more so I can understand.
> 
> FWIW, this is designed to be the test server spawned by SpawnedTestServer
> (replacing testserver.py for Android tests, so that we don't have to connect
> back to the host via the forwarder).

Right. I consider this goal a bad thing from the POV of //net, but I'm operating
on incomplete data (since no one I talked to brought up the use case on the bug)

We need to chat, because as is, I'm deeply concerned that this approach in the
CLs and bug is wrong. But I may also be mistaken.

> More context from the first CL in this
> sequence: https://codereview.chromium.org/867073002/
> 
> Happy to chat, though.

Powered by Google App Engine
This is Rietveld 408576698