Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 869083002: Remove DEFINE_STATIC_LOCAL in isDefaultPortForProtocol (Closed)

Created:
5 years, 11 months ago by kinuko
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove DEFINE_STATIC_LOCAL in isDefaultPortForProtocol Replacing this with AtomicallyInitializedStaticReference. BUG=373141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188885

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/platform/weborigin/KnownPorts.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kinuko
Fixing up easier ones... PTL
5 years, 11 months ago (2015-01-23 05:28:06 UTC) #3
Mike West
5 years, 11 months ago (2015-01-23 11:27:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869083002/20001
5 years, 11 months ago (2015-01-23 11:27:32 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-23 11:27:34 UTC) #8
Mike West
On 2015/01/23 at 11:27:17, Mike West wrote: > LGTM (sorry, clicked the wrong button)
5 years, 11 months ago (2015-01-23 11:27:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869083002/20001
5 years, 11 months ago (2015-01-23 11:27:55 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 13:40:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188885

Powered by Google App Engine
This is Rietveld 408576698