Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 869073006: Expose unsandboxed plugins (PPAPI) content setting to extensions. (Closed)

Created:
5 years, 10 months ago by msramek
Modified:
5 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose unsandboxed plugins (PPAPI) content setting to extensions. BUG=454799 Committed: https://crrev.com/4a9c978cae7dfb1a082f1694c65fdcd7e0d08560 Cr-Commit-Position: refs/heads/master@{#314551}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/api/content_settings.json View 1 chunk +8 lines, -0 lines 2 comments Download
M chrome/test/data/extensions/api_test/content_settings/standard/test.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
msramek
Hi Mike and Benjamin, here comes another batch of content settings for extensions. PTAL. Thanks, ...
5 years, 10 months ago (2015-02-03 17:56:43 UTC) #2
not at google - send to devlin
lgtm (btw I'm giving these all a very cursory skim, and assuming Mike will be ...
5 years, 10 months ago (2015-02-03 18:29:30 UTC) #3
Mike West
LGTM. https://codereview.chromium.org/869073006/diff/1/chrome/common/extensions/api/content_settings.json File chrome/common/extensions/api/content_settings.json (right): https://codereview.chromium.org/869073006/diff/1/chrome/common/extensions/api/content_settings.json#newcode266 chrome/common/extensions/api/content_settings.json:266: "description": "Whether to allow sites to run plug-ins ...
5 years, 10 months ago (2015-02-03 20:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869073006/1
5 years, 10 months ago (2015-02-04 12:03:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 13:01:27 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 13:02:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a9c978cae7dfb1a082f1694c65fdcd7e0d08560
Cr-Commit-Position: refs/heads/master@{#314551}

Powered by Google App Engine
This is Rietveld 408576698