[Local NTP] Add role="presentation" on the New Tab Page iframe.

[Local NTP] Add role="presentation" on the New Tab Page iframes.

BUG=449748
Committed: https://crrev.com/18f67dbe0652d388c168db1ceb7c7f379f84ad92
Cr-Commit-Position: refs/heads/master@{#313762}

[Mathieu, 2015-01-29 18:42:04]

mathp@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Mathieu, 2015-01-29 18:42:12]

Hi Dominic, have a look!

[dmazzoni, 2015-01-29 18:48:44]

lgtm

Thanks!

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:701: // Make the iframe
invisible to screen readers.
Let's reword this slightly. It implies that we're hiding the whole frame and its
contents. How about something like:

// Make the iframe presentational for accessibility so screen readers perceive
the iframe content as just part of the same page.

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:737:
titleElem.setAttribute('role', 'presentation');
This one is unnecessary, the iframe is already invisible to screen readers due
to aria-hidden

[Mathieu, 2015-01-29 18:53:35]

Thanks dominic, will submit.

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:701: // Make the iframe
invisible to screen readers.
On 2015/01/29 18:48:44, dmazzoni wrote:
> Let's reword this slightly. It implies that we're hiding the whole frame and
its
> contents. How about something like:
> 
> // Make the iframe presentational for accessibility so screen readers perceive
> the iframe content as just part of the same page.

Done.

https://codereview.chromium.org/869073004/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:737:
titleElem.setAttribute('role', 'presentation');
On 2015/01/29 18:48:43, dmazzoni wrote:
> This one is unnecessary, the iframe is already invisible to screen readers due
> to aria-hidden

Done.

[Mathieu, 2015-01-29 18:54:13]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2015-01-29 18:54:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869073004/20001

[commit-bot: I haz the power, 2015-01-29 19:47:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-29 19:48:30]

Patchset 2 (id:??) landed as
https://crrev.com/18f67dbe0652d388c168db1ceb7c7f379f84ad92
Cr-Commit-Position: refs/heads/master@{#313762}