Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 869063004: Remove iterator typedefs for USB descriptor types. (Closed)

Created:
5 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove iterator typedefs for USB descriptor types. C++11 range-based for loops make it a lot easier to iterate over an STL container without incredibly long type names. The last users of these typedefs have been updated and so they are no longer necessary. BUG= Committed: https://crrev.com/61aa5180a1fbbd40722d96433b3fb2ca5a328ee1 Cr-Commit-Position: refs/heads/master@{#312949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M device/usb/usb_descriptors.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Vince, please take a look at this trivial patch to remove some unused typedefs.
5 years, 11 months ago (2015-01-23 21:38:01 UTC) #2
scheib
lgtm
5 years, 11 months ago (2015-01-23 22:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869063004/1
5 years, 11 months ago (2015-01-23 22:18:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 22:27:31 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:28:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61aa5180a1fbbd40722d96433b3fb2ca5a328ee1
Cr-Commit-Position: refs/heads/master@{#312949}

Powered by Google App Engine
This is Rietveld 408576698