Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 869053005: Minor text changes on Advanced Sync Settings (Closed)

Created:
5 years, 10 months ago by Gang Wu
Modified:
5 years, 10 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor text changes on Advanced Sync Settings UI review wants us to use sentence case throughout on chrome://settings/syncSetup. "Open Tabs" -> "Open tabs" [ChromeOS only] "Themes & Wallpapers" -> "Themes & wallpapers" BUG=447405 Committed: https://crrev.com/55f189aa605f42b89c38c6448c4f18ce66fd155c Cr-Commit-Position: refs/heads/master@{#315410}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Gang Wu
please take a look
5 years, 10 months ago (2015-02-09 18:41:29 UTC) #2
Nicolas Zea
FYI no need to modify the language specific file. The translation teams will take care ...
5 years, 10 months ago (2015-02-09 20:36:59 UTC) #3
Gang Wu
updated the CL
5 years, 10 months ago (2015-02-09 21:07:01 UTC) #5
Nicolas Zea
LGTM
5 years, 10 months ago (2015-02-09 21:12:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869053005/20001
5 years, 10 months ago (2015-02-09 21:16:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 22:36:03 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:36:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55f189aa605f42b89c38c6448c4f18ce66fd155c
Cr-Commit-Position: refs/heads/master@{#315410}

Powered by Google App Engine
This is Rietveld 408576698