Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 869053004: Initialize render_frame_message_source_ in WebContentsImpl ctor. (Closed)

Created:
5 years, 11 months ago by Jun Mukai
Modified:
5 years, 11 months ago
Reviewers:
Charlie Reis, jam, inferno
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, keishi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize render_frame_message_source_ in WebContentsImpl ctor. Yet another cluster-fuzz crash happens due to invalid render_frame_message_source_. As I see the code, this field is always reset to NULL at the every IPC message but not initialized at all, therefore the crash may still happen if the message is the very first message to the object. BUG=451755 R=jam@chromium.org Committed: https://crrev.com/1db093769786287b1a34ef49c30ecf6bf64a7bfc Cr-Commit-Position: refs/heads/master@{#313335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Jun Mukai
5 years, 11 months ago (2015-01-25 23:59:39 UTC) #1
Charlie Reis
LGTM.
5 years, 11 months ago (2015-01-26 01:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869053004/1
5 years, 11 months ago (2015-01-26 06:49:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18175) Try jobs failed on following ...
5 years, 11 months ago (2015-01-26 07:52:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869053004/1
5 years, 11 months ago (2015-01-26 18:08:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18175)
5 years, 11 months ago (2015-01-26 18:08:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869053004/1
5 years, 11 months ago (2015-01-27 18:32:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18299)
5 years, 11 months ago (2015-01-27 19:05:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869053004/1
5 years, 11 months ago (2015-01-27 19:38:20 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 20:07:24 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 20:09:28 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1db093769786287b1a34ef49c30ecf6bf64a7bfc
Cr-Commit-Position: refs/heads/master@{#313335}

Powered by Google App Engine
This is Rietveld 408576698