Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 869013002: Shift polymer.html imports to custom elements. (Closed)

Created:
5 years, 11 months ago by Alexandre Carlton
Modified:
5 years, 10 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shift polymer.html imports to custom elements. Move the polymer.html into the individual custom elements (such as viewer-progress-bar) from index.html and index-material.html. Committed: https://crrev.com/df01d14d8f5f4d66f61adba62a46d30fee8d811a Cr-Commit-Position: refs/heads/master@{#313462}

Patch Set 1 #

Messages

Total messages: 13 (2 generated)
Alexandre Carlton
5 years, 11 months ago (2015-01-23 00:58:38 UTC) #2
benwells
This basically lg but I'm interested to know why you're doing this. Is this approach ...
5 years, 11 months ago (2015-01-27 02:16:25 UTC) #3
Alexandre Carlton
On 2015/01/27 02:16:25, benwells wrote: > This basically lg but I'm interested to know why ...
5 years, 11 months ago (2015-01-27 03:01:17 UTC) #4
benwells
On 2015/01/27 03:01:17, Alexandre Carlton wrote: > On 2015/01/27 02:16:25, benwells wrote: > > This ...
5 years, 11 months ago (2015-01-27 04:25:46 UTC) #5
Alexandre Carlton
On 2015/01/27 04:25:46, benwells wrote: > On 2015/01/27 03:01:17, Alexandre Carlton wrote: > > On ...
5 years, 11 months ago (2015-01-27 04:29:28 UTC) #6
benwells
On 2015/01/27 04:29:28, Alexandre Carlton wrote: > On 2015/01/27 04:25:46, benwells wrote: > > On ...
5 years, 11 months ago (2015-01-27 04:55:39 UTC) #7
raymes
lgtm
5 years, 11 months ago (2015-01-28 01:51:11 UTC) #8
Sam McNally
lgtm
5 years, 11 months ago (2015-01-28 02:47:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869013002/1
5 years, 10 months ago (2015-01-28 07:53:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 08:47:49 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 08:48:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df01d14d8f5f4d66f61adba62a46d30fee8d811a
Cr-Commit-Position: refs/heads/master@{#313462}

Powered by Google App Engine
This is Rietveld 408576698