Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 869003004: Revert of CrWinClang: Swarm content_unittests, net_unittests, unit_tests, browser_tests. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CrWinClang: Swarm content_unittests, net_unittests, unit_tests, browser_tests. (patchset #1 id:1 of https://codereview.chromium.org/859303007/) Reason for revert: Didn't work, isolate tests step still throws a MemoryError Original issue's description: > CrWinClang: Swarm content_unittests, net_unittests, unit_tests, browser_tests. > > Now that isolate archival no longer dies as quickly, this should work. > > BUG=446368, 419862 > R=maruel@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/c1275273c2674e3b4a12e3e096dc5a6ae02374af TBR=maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446368, 419862 Committed: https://crrev.com/5dfdf4f834d542e7d5c81dc2f3fe34fb0265a9f3 Cr-Commit-Position: refs/heads/master@{#312773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +10 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of CrWinClang: Swarm content_unittests, net_unittests, unit_tests, browser_tests.
5 years, 11 months ago (2015-01-23 05:19:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003004/1
5 years, 11 months ago (2015-01-23 05:20:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 05:22:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5dfdf4f834d542e7d5c81dc2f3fe34fb0265a9f3 Cr-Commit-Position: refs/heads/master@{#312773}
5 years, 11 months ago (2015-01-23 05:22:59 UTC) #4
Nico
5 years, 10 months ago (2015-02-10 06:04:43 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/893313006/ by thakis@chromium.org.

The reason for reverting is: Let's try this again now that the clang/win bots
use fastbuild (crbug.com/455966).

Powered by Google App Engine
This is Rietveld 408576698