Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869003003: Add RealPanWalletClient for handling card unmasking requests. (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
Reviewers:
brettw, jstuppy
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RealPanWalletClient for handling card unmasking requests. BUG=451286 Committed: https://crrev.com/284ea7af95f2cd99b7d35beaf4be60e214dbc992 Cr-Commit-Position: refs/heads/master@{#312995}

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 6

Patch Set 3 : brettw review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -1 line) Patch
M components/autofill.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 4 chunks +10 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 4 chunks +16 lines, -0 lines 0 comments Download
A components/autofill/core/browser/wallet/real_pan_wallet_client.h View 1 chunk +76 lines, -0 lines 0 comments Download
A components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 1 2 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Evan Stade
5 years, 11 months ago (2015-01-23 02:05:16 UTC) #2
brettw
lgtm https://codereview.chromium.org/869003003/diff/20001/components/autofill.gypi File components/autofill.gypi (right): https://codereview.chromium.org/869003003/diff/20001/components/autofill.gypi#newcode190 components/autofill.gypi:190: 'autofill/core/browser/wallet/real_pan_wallet_client.cc', Add to BUILD.gn file? https://codereview.chromium.org/869003003/diff/20001/components/autofill/core/browser/wallet/real_pan_wallet_client.cc File components/autofill/core/browser/wallet/real_pan_wallet_client.cc ...
5 years, 11 months ago (2015-01-23 17:56:10 UTC) #3
Evan Stade
https://codereview.chromium.org/869003003/diff/20001/components/autofill.gypi File components/autofill.gypi (right): https://codereview.chromium.org/869003003/diff/20001/components/autofill.gypi#newcode190 components/autofill.gypi:190: 'autofill/core/browser/wallet/real_pan_wallet_client.cc', On 2015/01/23 17:56:10, brettw wrote: > Add to ...
5 years, 11 months ago (2015-01-23 22:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003003/40001
5 years, 11 months ago (2015-01-23 22:15:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/26637)
5 years, 11 months ago (2015-01-23 23:44:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003003/40001
5 years, 11 months ago (2015-01-24 00:17:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/26637)
5 years, 11 months ago (2015-01-24 00:17:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003003/40001
5 years, 11 months ago (2015-01-24 01:44:08 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-24 02:10:27 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 02:12:24 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/284ea7af95f2cd99b7d35beaf4be60e214dbc992
Cr-Commit-Position: refs/heads/master@{#312995}

Powered by Google App Engine
This is Rietveld 408576698