Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 869003002: Experimental tuning for DirectWrite font cache. (Closed)

Created:
5 years, 11 months ago by Shrikant Kelkar
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experimental tuning for DirectWrite font cache. I don't expect significant improvment with such little tuning, but want to test it with more user base to see the direction. Here is the summary of experiments I did on my machine. I have total of 454 font files on my system. Percent of file content cached: 85%, File Size: 35MB Cached fonts: 422 (92%) Percent of file content cached: 75% File Size: 29MB Cached fonts 335 (73%) Percent of file content cached: 65% File Size: 24MB Cached fonts: 240 (52%) Percent of file content cached: 60% File Size: 23MB Cached fonts 236 (51%) Percent of file content cached: 50% File Size: 13MB Cached fonts 231 (50%) BUG=449687 R=cpu,scottmg,ananta Committed: https://crrev.com/cddd0218013b6611389c184050fe6a4daacc778e Cr-Commit-Position: refs/heads/master@{#313020}

Patch Set 1 #

Patch Set 2 : Removed newly added blank line. #

Patch Set 3 : Modified font test data files for content tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/common/dwrite_font_platform_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/data/font/dwrite_font_cache_arial.dat View 1 2 Binary file 0 comments Download
M content/test/data/font/dwrite_font_cache_corrupt.dat View 1 2 Binary file 0 comments Download

Messages

Total messages: 18 (5 generated)
Shrikant Kelkar
5 years, 11 months ago (2015-01-23 00:48:59 UTC) #1
scottmg
I guess it's ok to play around with, so lgtm, but is there some way ...
5 years, 11 months ago (2015-01-23 01:22:23 UTC) #2
Shrikant Kelkar
On 2015/01/23 01:22:23, scottmg wrote: > I guess it's ok to play around with, so ...
5 years, 11 months ago (2015-01-23 01:25:45 UTC) #3
scottmg
On 2015/01/23 01:25:45, Shrikant Kelkar wrote: > On 2015/01/23 01:22:23, scottmg wrote: > > I ...
5 years, 11 months ago (2015-01-23 01:36:08 UTC) #4
Shrikant Kelkar
On 2015/01/23 01:36:08, scottmg wrote: > On 2015/01/23 01:25:45, Shrikant Kelkar wrote: > > On ...
5 years, 11 months ago (2015-01-23 01:46:21 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-24 00:00:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003002/20001
5 years, 11 months ago (2015-01-24 00:01:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/19318)
5 years, 11 months ago (2015-01-24 01:40:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003002/40001
5 years, 11 months ago (2015-01-24 01:51:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/19366)
5 years, 11 months ago (2015-01-24 03:54:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869003002/40001
5 years, 11 months ago (2015-01-24 15:29:08 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-24 15:29:57 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 15:31:03 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cddd0218013b6611389c184050fe6a4daacc778e
Cr-Commit-Position: refs/heads/master@{#313020}

Powered by Google App Engine
This is Rietveld 408576698