Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 868993002: Land Recent QUIC Changes. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Remove unused QuicDecrypter::Decrypt method and implementations. Merge internal change: 84548556 https://codereview.chromium.org/868953002/ Changed verify_details_ check to verify_details_.get() to keep code in sync with internal source. Merge internal change: 84442484 https://codereview.chromium.org/872483002/ Removing an obselete TOOD. It is obselte becasue FrameOverlapsBufferedData does this. Merge internal change: 84372263 https://codereview.chromium.org/871733002/ Replace the map in QuicAckNotifier with a counter. No functionality change. This reduces memory and CPU usage of the ack notifier. Merge internal change: 84345868 https://codereview.chromium.org/867033002/ Change some of QUIC's AckNotifier datastructures from maps to hashmaps and sets to lists. No behavior change. This should reduce CPU consumption substantially, particularly on internal servers. Merge internal change: 84156430 https://codereview.chromium.org/870733002/ Add a new RTO connection option to QUIC. Flag protected behind the existing flag FLAGS_quic_use_new_rto. This new RTO connection option uses loss detection to reduce the congestion window after an RTO, instead of always reducing the CWND to 2. Merge internal change: 84036848 https://codereview.chromium.org/824693007/ QUIC - sync'ing with internal source tree changes. Minor change to keep the code similar to chromium and internal tree. Merge internal change: 83993217 https://codereview.chromium.org/870723002/ Fix a bug in QUIC's RTO. Flag protected by FLAGS_quic_use_new_rto. Ensures a beta based loss reduction is not triggered directly before OnRetransmissionTimeout when recovering from RTO. Merge internal change: 83986840 https://codereview.chromium.org/868813003/ R=rch@chromium.org Committed: https://crrev.com/cf54a52c111f2f2d9a1b77a13a8fc8a064261459 Cr-Commit-Position: refs/heads/master@{#313081}

Patch Set 1 #

Patch Set 2 : use assign #

Patch Set 3 : minor style cleanup - call all decrypter related methods at the same time #

Patch Set 4 : Merging with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -186 lines) Patch
M net/quic/crypto/aead_base_decrypter.h View 2 chunks +6 lines, -5 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_test.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter_test.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_secret_boxer.cc View 1 2 1 chunk +13 lines, -10 lines 0 comments Download
M net/quic/crypto/null_decrypter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/crypto/null_decrypter.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M net/quic/crypto/quic_decrypter.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/quic_ack_notifier.h View 1 2 3 2 chunks +7 lines, -17 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 3 chunks +9 lines, -31 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.h View 3 chunks +8 lines, -3 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/quic_packet_generator.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +77 lines, -1 line 0 comments Download
M net/quic/quic_stream_sequencer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ramant (doing other things)
5 years, 11 months ago (2015-01-23 00:42:55 UTC) #1
ramant (doing other things)
Hi Ryan, This is a merged of all CL's you have already LGTM'ed. Used "assign" ...
5 years, 11 months ago (2015-01-23 23:09:35 UTC) #5
Ryan Hamilton
lgtm sorry for the delay!
5 years, 11 months ago (2015-01-26 03:48:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868993002/20002
5 years, 11 months ago (2015-01-26 16:22:43 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:20002)
5 years, 11 months ago (2015-01-26 17:02:22 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 17:03:08 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cf54a52c111f2f2d9a1b77a13a8fc8a064261459
Cr-Commit-Position: refs/heads/master@{#313081}

Powered by Google App Engine
This is Rietveld 408576698