Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: gm/imagefilterscropped.cpp

Issue 868973005: Revert of Fix Morphology effects sourcing outside of the crop rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/effects/SkMorphologyImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkColorFilter.h" 10 #include "SkColorFilter.h"
11 #include "SkColorPriv.h" 11 #include "SkColorPriv.h"
12 #include "SkShader.h" 12 #include "SkShader.h"
13 13
14 #include "SkBlurImageFilter.h" 14 #include "SkBlurImageFilter.h"
15 #include "SkMorphologyImageFilter.h"
16 #include "SkColorFilterImageFilter.h" 15 #include "SkColorFilterImageFilter.h"
17 #include "SkBitmapSource.h"
18 #include "SkMergeImageFilter.h" 16 #include "SkMergeImageFilter.h"
19 #include "SkOffsetImageFilter.h" 17 #include "SkOffsetImageFilter.h"
20 #include "SkTestImageFilters.h" 18 #include "SkTestImageFilters.h"
21 19
22 /////////////////////////////////////////////////////////////////////////////// 20 ///////////////////////////////////////////////////////////////////////////////
23 21
24 static void draw_paint(SkCanvas* canvas, const SkRect& r, SkImageFilter* imf) { 22 static void draw_paint(SkCanvas* canvas, const SkRect& r, SkImageFilter* imf) {
25 SkPaint paint; 23 SkPaint paint;
26 paint.setImageFilter(imf); 24 paint.setImageFilter(imf);
27 paint.setColor(SK_ColorBLACK); 25 paint.setColor(SK_ColorBLACK);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 91
94 class ImageFiltersCroppedGM : public skiagm::GM { 92 class ImageFiltersCroppedGM : public skiagm::GM {
95 public: 93 public:
96 ImageFiltersCroppedGM () {} 94 ImageFiltersCroppedGM () {}
97 95
98 protected: 96 protected:
99 virtual SkString onShortName() { 97 virtual SkString onShortName() {
100 return SkString("imagefilterscropped"); 98 return SkString("imagefilterscropped");
101 } 99 }
102 100
103 virtual SkISize onISize() { return SkISize::Make(400, 880); } 101 virtual SkISize onISize() { return SkISize::Make(400, 640); }
104
105 void make_checkerboard() {
106 fCheckerboard.allocN32Pixels(80, 80);
107 SkCanvas canvas(fCheckerboard);
108 canvas.clear(SK_ColorTRANSPARENT);
109 SkPaint darkPaint;
110 darkPaint.setColor(0xFF404040);
111 SkPaint lightPaint;
112 lightPaint.setColor(0xFFA0A0A0);
113 for (int y = 0; y < 80; y += 16) {
114 for (int x = 0; x < 80; x += 16) {
115 canvas.save();
116 canvas.translate(SkIntToScalar(x), SkIntToScalar(y));
117 canvas.drawRect(SkRect::MakeXYWH(0, 0, 8, 8), darkPaint);
118 canvas.drawRect(SkRect::MakeXYWH(8, 0, 8, 8), lightPaint);
119 canvas.drawRect(SkRect::MakeXYWH(0, 8, 8, 8), lightPaint);
120 canvas.drawRect(SkRect::MakeXYWH(8, 8, 8, 8), darkPaint);
121 canvas.restore();
122 }
123 }
124 }
125 102
126 void draw_frame(SkCanvas* canvas, const SkRect& r) { 103 void draw_frame(SkCanvas* canvas, const SkRect& r) {
127 SkPaint paint; 104 SkPaint paint;
128 paint.setStyle(SkPaint::kStroke_Style); 105 paint.setStyle(SkPaint::kStroke_Style);
129 paint.setColor(SK_ColorRED); 106 paint.setColor(SK_ColorRED);
130 canvas->drawRect(r, paint); 107 canvas->drawRect(r, paint);
131 } 108 }
132 109
133 virtual void onOnceBeforeDraw() SK_OVERRIDE{
134 make_checkerboard();
135 }
136
137 virtual void onDraw(SkCanvas* canvas) { 110 virtual void onDraw(SkCanvas* canvas) {
138 void (*drawProc[])(SkCanvas*, const SkRect&, SkImageFilter*) = { 111 void (*drawProc[])(SkCanvas*, const SkRect&, SkImageFilter*) = {
139 draw_sprite, draw_bitmap, draw_path, draw_paint, draw_text 112 draw_sprite, draw_bitmap, draw_path, draw_paint, draw_text
140 }; 113 };
141 114
142 SkAutoTUnref<SkColorFilter> cf( 115 SkAutoTUnref<SkColorFilter> cf(
143 SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mod e)); 116 SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mod e));
144 SkImageFilter::CropRect cropRect(SkRect::Make(SkIRect::MakeXYWH(10, 10, 44, 44)), SkImageFilter::CropRect::kHasAll_CropEdge); 117 SkImageFilter::CropRect cropRect(SkRect::Make(SkIRect::MakeXYWH(10, 10, 44, 44)), SkImageFilter::CropRect::kHasAll_CropEdge);
145 SkImageFilter::CropRect bogusRect(SkRect::Make(SkIRect::MakeXYWH(-100, - 100, 10, 10)), SkImageFilter::CropRect::kHasAll_CropEdge); 118 SkImageFilter::CropRect bogusRect(SkRect::Make(SkIRect::MakeXYWH(-100, - 100, 10, 10)), SkImageFilter::CropRect::kHasAll_CropEdge);
146 119
147 SkAutoTUnref<SkImageFilter> offset(SkOffsetImageFilter::Create( 120 SkAutoTUnref<SkImageFilter> offset(SkOffsetImageFilter::Create(
148 SkIntToScalar(-10), SkIntToScalar(-10))); 121 SkIntToScalar(-10), SkIntToScalar(-10)));
149 122
150 SkAutoTUnref<SkImageFilter> cfOffset(SkColorFilterImageFilter::Create(cf .get(), offset.get())); 123 SkAutoTUnref<SkImageFilter> cfOffset(SkColorFilterImageFilter::Create(cf .get(), offset.get()));
124
151 SkImageFilter* filters[] = { 125 SkImageFilter* filters[] = {
152 NULL, 126 NULL,
153 SkColorFilterImageFilter::Create(cf.get(), NULL, &cropRect), 127 SkColorFilterImageFilter::Create(cf.get(), NULL, &cropRect),
154 SkBlurImageFilter::Create(1.0f, 1.0f, NULL, &cropRect), 128 SkBlurImageFilter::Create(1.0f, 1.0f, NULL, &cropRect),
155 SkBlurImageFilter::Create(8.0f, 0.0f, NULL, &cropRect), 129 SkBlurImageFilter::Create(8.0f, 0.0f, NULL, &cropRect),
156 SkBlurImageFilter::Create(0.0f, 8.0f, NULL, &cropRect), 130 SkBlurImageFilter::Create(0.0f, 8.0f, NULL, &cropRect),
157 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &cropRect), 131 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &cropRect),
158 SkErodeImageFilter::Create(1, 1, NULL, &cropRect),
159 SkErodeImageFilter::Create(8, 0, SkErodeImageFilter::Create(0, 8, NU LL, &cropRect), &cropRect),
160 SkErodeImageFilter::Create(0, 8, SkErodeImageFilter::Create(8, 0, NU LL, &cropRect), &cropRect),
161 SkErodeImageFilter::Create(8, 8, NULL, &cropRect),
162 SkMergeImageFilter::Create(NULL, cfOffset.get(), SkXfermode::kSrcOve r_Mode, &cropRect), 132 SkMergeImageFilter::Create(NULL, cfOffset.get(), SkXfermode::kSrcOve r_Mode, &cropRect),
163 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &bogusRect), 133 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &bogusRect),
164 SkColorFilterImageFilter::Create(cf.get(), NULL, &bogusRect), 134 SkColorFilterImageFilter::Create(cf.get(), NULL, &bogusRect),
165 }; 135 };
166 136
167 SkRect r = SkRect::MakeWH(SkIntToScalar(64), SkIntToScalar(64)); 137 SkRect r = SkRect::MakeWH(SkIntToScalar(64), SkIntToScalar(64));
168 SkScalar MARGIN = SkIntToScalar(16); 138 SkScalar MARGIN = SkIntToScalar(16);
169 SkScalar DX = r.width() + MARGIN; 139 SkScalar DX = r.width() + MARGIN;
170 SkScalar DY = r.height() + MARGIN; 140 SkScalar DY = r.height() + MARGIN;
171 141
172 canvas->translate(MARGIN, MARGIN); 142 canvas->translate(MARGIN, MARGIN);
173 for (size_t j = 0; j < SK_ARRAY_COUNT(drawProc); ++j) { 143 for (size_t j = 0; j < SK_ARRAY_COUNT(drawProc); ++j) {
174 canvas->save(); 144 canvas->save();
175 for (size_t i = 0; i < SK_ARRAY_COUNT(filters); ++i) { 145 for (size_t i = 0; i < SK_ARRAY_COUNT(filters); ++i) {
176 SkPaint paint;
177 canvas->drawBitmap(fCheckerboard, 0, 0);
178 drawProc[j](canvas, r, filters[i]); 146 drawProc[j](canvas, r, filters[i]);
179 canvas->translate(0, DY); 147 canvas->translate(0, DY);
180 } 148 }
181 canvas->restore(); 149 canvas->restore();
182 canvas->translate(DX, 0); 150 canvas->translate(DX, 0);
183 } 151 }
184 152
185 for(size_t j = 0; j < SK_ARRAY_COUNT(filters); ++j) { 153 for(size_t j = 0; j < SK_ARRAY_COUNT(filters); ++j) {
186 SkSafeUnref(filters[j]); 154 SkSafeUnref(filters[j]);
187 } 155 }
188 } 156 }
189 157
190 private: 158 private:
191 SkBitmap fCheckerboard;
192 typedef GM INHERITED; 159 typedef GM INHERITED;
193 }; 160 };
194 161
195 /////////////////////////////////////////////////////////////////////////////// 162 ///////////////////////////////////////////////////////////////////////////////
196 163
197 static skiagm::GM* MyFactory(void*) { return new ImageFiltersCroppedGM; } 164 static skiagm::GM* MyFactory(void*) { return new ImageFiltersCroppedGM; }
198 static skiagm::GMRegistry reg(MyFactory); 165 static skiagm::GMRegistry reg(MyFactory);
OLDNEW
« no previous file with comments | « no previous file | src/effects/SkMorphologyImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698