Simplify resolution of mojo: URLs.

shell/context.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SHELL_CONTEXT_H_
 #define SHELL_CONTEXT_H_
 
 #include <string>
 
 #include "base/macros.h"
 #include "shell/application_manager/application_manager.h"
 #include "shell/mojo_url_resolver.h"
 #include "shell/task_runners.h"
 
 namespace mojo {
 
 namespace shell {
 
 class DynamicApplicationLoader;
 class ExternalApplicationListener;
 
 // The "global" context for the shell's main process.
 class Context : ApplicationManager::Delegate {
  public:
   Context();
   ~Context() override;
 
+  void SetShellFileRoot(const base::FilePath& path);

[Aaron Boodman, 2015/01/27 00:37:13]

Maybe a better name would be: SetMojoURLRoot?

[Nick Bray (chromium), 2015/01/27 01:44:35]

I'll comment this, but the fact it is the _file_ root is quite important.  (It's
used to resolving things installed along with mojo_shell.)

+  GURL ResolveShellFileURL(const std::string& path);

[Aaron Boodman, 2015/01/27 00:37:13]

These two methods need comments.

[Nick Bray (chromium), 2015/01/27 01:44:35]

Done.  <troll>But you could say that's against the style of this particular
file.</troll>

[Aaron Boodman, 2015/01/27 07:29:54]

True, but the reason I brought this up in particular was that it wasn't at all
clear to me what a "shell file URL" was, whereas the other members of this class
are more self-explanatory, at least to me.

[Nick Bray (chromium), 2015/01/27 16:36:25]

More comments are always better, particularly when a reviewer asks for
clarification.  Pure trolling on my part.

+
   static void EnsureEmbedderIsInitialized();
   bool Init();
 
   void Run(const GURL& url);
   ScopedMessagePipeHandle ConnectToServiceByName(
       const GURL& application_url,
       const std::string& service_name);
 
   TaskRunners* task_runners() { return task_runners_.get(); }
   ApplicationManager* application_manager() { return &application_manager_; }
   MojoURLResolver* mojo_url_resolver() { return &mojo_url_resolver_; }
 
  private:
   class NativeViewportApplicationLoader;
 
   // ApplicationManager::Delegate override.
   void OnApplicationError(const GURL& url) override;
   GURL ResolveURL(const GURL& url) override;
   GURL ResolveMappings(const GURL& url) override;
 
   std::set<GURL> app_urls_;
   scoped_ptr<TaskRunners> task_runners_;
   scoped_ptr<ExternalApplicationListener> listener_;
   ApplicationManager application_manager_;
   MojoURLResolver mojo_url_resolver_;
+  GURL shell_file_root_;
 
   DISALLOW_COPY_AND_ASSIGN(Context);
 };
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // SHELL_CONTEXT_H_