content/renderer/render_widget.cc - Issue 868933002: [Contextual Search] Check ARIA Roles before triggering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 868933002: [Contextual Search] Check ARIA Roles before triggering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: None. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index 930ba87cf3fc2a818f0bc93cfa5072125b452d8c..0cc745b0473aa45e6b19f7157f99b398dda0fb34 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -2180,7 +2180,8 @@ void RenderWidget::showUnhandledTapUIIfNeeded(

bool page_changed) {

DCHECK(handling_input_event_);

bool should_trigger = !page_changed && tapped_node.isTextNode() &&

- !tapped_node.isContentEditable();

+ !tapped_node.isContentEditable() &&

+ !tapped_node.isInsideFocusableElementOrARIAWidget();

if (should_trigger) {

Send(new ViewHostMsg_ShowUnhandledTapUIIfNeeded(routing_id_,

tapped_position.x, tapped_position.y));

« no previous file with comments | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »