Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: runtime/vm/handles.h

Issue 868913002: Add Zone-based handle allocation interface and reduce use of Isolate-based interfaces. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/handles.h
===================================================================
--- runtime/vm/handles.h (revision 43075)
+++ runtime/vm/handles.h (working copy)
@@ -112,11 +112,11 @@
// Allocates a handle in the current handle scope. This handle is valid only
// in the current handle scope and is destroyed when the current handle
// scope ends.
- static uword AllocateHandle(Isolate* isolate);
+ static uword AllocateHandle(Zone* zone);
// Allocates a handle in the current zone. This handle will be destroyed
// when the current zone is destroyed.
- static uword AllocateZoneHandle(Isolate* isolate);
+ static uword AllocateZoneHandle(Zone* zone);
// Returns true if specified handle is a zone handle.
static bool IsZoneHandle(uword handle);
@@ -268,14 +268,14 @@
// Visit all object pointers stored in the various handles.
void VisitObjectPointers(ObjectPointerVisitor* visitor);
- // Allocates a handle in the current handle scope. This handle is valid only
- // in the current handle scope and is destroyed when the current handle
- // scope ends.
- static uword AllocateHandle(Isolate* isolate);
+ // Allocates a handle in the current handle scope of 'zone', which must be
+ // the current zone. This handle is valid only in the current handle scope
+ // and is destroyed when the current handle scope ends.
+ static uword AllocateHandle(Zone* zone);
- // Allocates a handle in the current zone. This handle will be destroyed
- // when the current zone is destroyed.
- static uword AllocateZoneHandle(Isolate* isolate);
+ // Allocates a handle in 'zone', which must be the current zone. This handle
+ // will be destroyed when the current zone is destroyed.
+ static uword AllocateZoneHandle(Zone* zone);
// Returns true if specified handle is a zone handle.
static bool IsZoneHandle(uword handle);

Powered by Google App Engine
This is Rietveld 408576698