Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Unified Diff: chrome/browser/views/tabs/dragged_tab_controller.cc

Issue 8689: Fix a couple of tab related bugs:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/frame/browser_view2.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/dragged_tab_controller.cc
===================================================================
--- chrome/browser/views/tabs/dragged_tab_controller.cc (revision 4025)
+++ chrome/browser/views/tabs/dragged_tab_controller.cc (working copy)
@@ -103,6 +103,11 @@
in_destructor_ = true;
CleanUpSourceTab();
MessageLoopForUI::current()->RemoveObserver(this);
+ // Need to delete the view here manually _before_ we reset the dragged
+ // contents to NULL, otherwise if the view is animating to its destination
+ // bounds, it won't be able to clean up properly since its cleanup routine
+ // uses GetIndexForDraggedContents, which will be invalid.
+ view_.reset(NULL);
ChangeDraggedContents(NULL); // This removes our observer.
}
« no previous file with comments | « chrome/browser/views/frame/browser_view2.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698