Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: build/common.gypi

Issue 868893004: Replace the asan_coverage GYP flag with sanitizer_coverage which is to be used with other sanitizer… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added the comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/common/sandbox_linux/sandbox_linux.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 # Run tools/clang/scripts/update.sh to make sure they are compiled. 384 # Run tools/clang/scripts/update.sh to make sure they are compiled.
385 # This causes 'clang_chrome_plugins_flags' to be set. 385 # This causes 'clang_chrome_plugins_flags' to be set.
386 # Has no effect if 'clang' is not set as well. 386 # Has no effect if 'clang' is not set as well.
387 'clang_use_chrome_plugins%': 1, 387 'clang_use_chrome_plugins%': 1,
388 388
389 # Enable building with ASAN (Clang's -fsanitize=address option). 389 # Enable building with ASAN (Clang's -fsanitize=address option).
390 # -fsanitize=address only works with clang, but asan=1 implies clang=1 390 # -fsanitize=address only works with clang, but asan=1 implies clang=1
391 # See https://sites.google.com/a/chromium.org/dev/developers/testing/addre sssanitizer 391 # See https://sites.google.com/a/chromium.org/dev/developers/testing/addre sssanitizer
392 'asan%': 0, 392 'asan%': 0,
393 'asan_blacklist%': '<(PRODUCT_DIR)/../../tools/memory/asan/blacklist.txt', 393 'asan_blacklist%': '<(PRODUCT_DIR)/../../tools/memory/asan/blacklist.txt',
394 # Enable coverage gathering instrumentation in ASan. This flag also 394 # Enable coverage gathering instrumentation in sanitizer tools. This flag
395 # controls coverage granularity (1 for function-level coverage, 2 for 395 # also controls coverage granularity (1 for function-level coverage, 2
396 # block-level coverage). 396 # for block-level coverage).
397 'sanitizer_coverage%': 0,
398 # Deprecated, only works if |sanitizer_coverage| isn't set.
399 # TODO(glider): remove this flag.
397 'asan_coverage%': 0, 400 'asan_coverage%': 0,
398 # Enable intra-object-overflow detection in ASan (experimental). 401 # Enable intra-object-overflow detection in ASan (experimental).
399 'asan_field_padding%': 0, 402 'asan_field_padding%': 0,
400 403
401 # Enable Chromium overrides of the default configurations for various 404 # Enable Chromium overrides of the default configurations for various
402 # dynamic tools (like ASan). 405 # dynamic tools (like ASan).
403 'use_sanitizer_options%': 0, 406 'use_sanitizer_options%': 0,
404 407
405 # Enable building with SyzyAsan. 408 # Enable building with SyzyAsan.
406 # See https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo 409 # See https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1112 'chromium_win_pch%': '<(chromium_win_pch)', 1115 'chromium_win_pch%': '<(chromium_win_pch)',
1113 'configuration_policy%': '<(configuration_policy)', 1116 'configuration_policy%': '<(configuration_policy)',
1114 'safe_browsing%': '<(safe_browsing)', 1117 'safe_browsing%': '<(safe_browsing)',
1115 'enable_web_speech%': '<(enable_web_speech)', 1118 'enable_web_speech%': '<(enable_web_speech)',
1116 'notifications%': '<(notifications)', 1119 'notifications%': '<(notifications)',
1117 'clang_use_chrome_plugins%': '<(clang_use_chrome_plugins)', 1120 'clang_use_chrome_plugins%': '<(clang_use_chrome_plugins)',
1118 'mac_want_real_dsym%': '<(mac_want_real_dsym)', 1121 'mac_want_real_dsym%': '<(mac_want_real_dsym)',
1119 'asan%': '<(asan)', 1122 'asan%': '<(asan)',
1120 'asan_blacklist%': '<(asan_blacklist)', 1123 'asan_blacklist%': '<(asan_blacklist)',
1121 'asan_coverage%': '<(asan_coverage)', 1124 'asan_coverage%': '<(asan_coverage)',
1125 'sanitizer_coverage%': '<(sanitizer_coverage)',
1122 'asan_field_padding%': '<(asan_field_padding)', 1126 'asan_field_padding%': '<(asan_field_padding)',
1123 'use_sanitizer_options%': '<(use_sanitizer_options)', 1127 'use_sanitizer_options%': '<(use_sanitizer_options)',
1124 'syzyasan%': '<(syzyasan)', 1128 'syzyasan%': '<(syzyasan)',
1125 'syzygy_optimize%': '<(syzygy_optimize)', 1129 'syzygy_optimize%': '<(syzygy_optimize)',
1126 'lsan%': '<(lsan)', 1130 'lsan%': '<(lsan)',
1127 'msan%': '<(msan)', 1131 'msan%': '<(msan)',
1128 'msan_blacklist%': '<(msan_blacklist)', 1132 'msan_blacklist%': '<(msan_blacklist)',
1129 'msan_track_origins%': '<(msan_track_origins)', 1133 'msan_track_origins%': '<(msan_track_origins)',
1130 'tsan%': '<(tsan)', 1134 'tsan%': '<(tsan)',
1131 'tsan_blacklist%': '<(tsan_blacklist)', 1135 'tsan_blacklist%': '<(tsan_blacklist)',
(...skipping 3108 matching lines...) Expand 10 before | Expand all | Expand 10 after
4240 ], 4244 ],
4241 'ldflags': [ 4245 'ldflags': [
4242 '-fsanitize=vptr', 4246 '-fsanitize=vptr',
4243 ], 4247 ],
4244 'defines': [ 4248 'defines': [
4245 'UNDEFINED_SANITIZER', 4249 'UNDEFINED_SANITIZER',
4246 ], 4250 ],
4247 }], 4251 }],
4248 ], 4252 ],
4249 }], 4253 }],
4250 ['asan_coverage!=0', { 4254 ['asan_coverage!=0 and sanitizer_coverage==0', {
4251 'target_conditions': [ 4255 'target_conditions': [
4252 ['_toolset=="target"', { 4256 ['_toolset=="target"', {
4253 'cflags': [ 4257 'cflags': [
4254 '-fsanitize-coverage=<(asan_coverage)', 4258 '-fsanitize-coverage=<(asan_coverage)',
4255 ], 4259 ],
4260 'defines': [
4261 'SANITIZER_COVERAGE',
4262 ],
4256 }], 4263 }],
4257 ], 4264 ],
4258 }], 4265 }],
4266 ['sanitizer_coverage!=0', {
4267 'target_conditions': [
4268 ['_toolset=="target"', {
4269 'cflags': [
4270 '-fsanitize-coverage=<(sanitizer_coverage)',
4271 ],
4272 'defines': [
4273 'SANITIZER_COVERAGE',
4274 ],
4275 }],
4276 ],
4277 }],
4259 ['asan_field_padding!=0', { 4278 ['asan_field_padding!=0', {
4260 'target_conditions': [ 4279 'target_conditions': [
4261 ['_toolset=="target"', { 4280 ['_toolset=="target"', {
4262 'cflags': [ 4281 'cflags': [
4263 '-fsanitize-address-field-padding=<(asan_field_padding)', 4282 '-fsanitize-address-field-padding=<(asan_field_padding)',
4264 ], 4283 ],
4265 }], 4284 }],
4266 ], 4285 ],
4267 }], 4286 }],
4268 ['lsan==1', { 4287 ['lsan==1', {
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
4904 }], 4923 }],
4905 ['asan==1', { 4924 ['asan==1', {
4906 'xcode_settings': { 4925 'xcode_settings': {
4907 'OTHER_CFLAGS': [ 4926 'OTHER_CFLAGS': [
4908 '-fsanitize=address', 4927 '-fsanitize=address',
4909 '-mllvm -asan-globals=0', # http://crbug.com/352073 4928 '-mllvm -asan-globals=0', # http://crbug.com/352073
4910 '-gline-tables-only', 4929 '-gline-tables-only',
4911 ], 4930 ],
4912 }, 4931 },
4913 }], 4932 }],
4914 ['asan_coverage!=0', { 4933 ['asan_coverage!=0 and sanitizer_coverage==0', {
4915 'target_conditions': [ 4934 'target_conditions': [
4916 ['_toolset=="target"', { 4935 ['_toolset=="target"', {
4917 'cflags': [ 4936 'cflags': [
4918 '-fsanitize-coverage=<(asan_coverage)', 4937 '-fsanitize-coverage=<(asan_coverage)',
4919 ], 4938 ],
4939 'defines': [
4940 'SANITIZER_COVERAGE',
4941 ],
4920 }], 4942 }],
4921 ], 4943 ],
4922 }], 4944 }],
4945 ['sanitizer_coverage!=0', {
4946 'target_conditions': [
4947 ['_toolset=="target"', {
4948 'cflags': [
4949 '-fsanitize-coverage=<(sanitizer_coverage)',
4950 ],
4951 'defines': [
4952 'SANITIZER_COVERAGE',
4953 ],
4954 }],
4955 ],
4956 }],
4923 ], 4957 ],
4924 'target_conditions': [ 4958 'target_conditions': [
4925 ['_type!="static_library"', { 4959 ['_type!="static_library"', {
4926 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, 4960 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']},
4927 'conditions': [ 4961 'conditions': [
4928 ['asan==1', { 4962 ['asan==1', {
4929 'xcode_settings': { 4963 'xcode_settings': {
4930 'OTHER_LDFLAGS': [ 4964 'OTHER_LDFLAGS': [
4931 '-fsanitize=address', 4965 '-fsanitize=address',
4932 ], 4966 ],
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
5872 # settings in target dicts. SYMROOT is a special case, because many other 5906 # settings in target dicts. SYMROOT is a special case, because many other
5873 # Xcode variables depend on it, including variables such as 5907 # Xcode variables depend on it, including variables such as
5874 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5908 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5875 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5909 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5876 # files to appear (when present) in the UI as actual files and not red 5910 # files to appear (when present) in the UI as actual files and not red
5877 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5911 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5878 # and therefore SYMROOT, needs to be set at the project level. 5912 # and therefore SYMROOT, needs to be set at the project level.
5879 'SYMROOT': '<(DEPTH)/xcodebuild', 5913 'SYMROOT': '<(DEPTH)/xcodebuild',
5880 }, 5914 },
5881 } 5915 }
OLDNEW
« no previous file with comments | « no previous file | content/common/sandbox_linux/sandbox_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698