Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 868893004: Replace the asan_coverage GYP flag with sanitizer_coverage which is to be used with other sanitizer… (Closed)

Created:
5 years, 11 months ago by Alexander Potapenko
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the asan_coverage GYP flag with sanitizer_coverage which is to be used with other sanitizers. Introduce the SANITIZER_COVERAGE define. BUG=444896 R=earthdok@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/ddea13be3be19fd889fb5953470faf154836e973 Cr-Commit-Position: refs/heads/master@{#316241}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -23 lines) Patch
M build/common.gypi View 1 4 chunks +39 lines, -5 lines 0 comments Download
M content/common/sandbox_linux/sandbox_linux.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Alexander Potapenko
On 2015/01/23 11:40:33, Alexander Potapenko wrote: > mailto:glider@chromium.org changed reviewers: > + mailto:earthdok@chromium.org Sergey, can ...
5 years, 11 months ago (2015-01-23 11:41:03 UTC) #2
earthdok
lgtm w/nit https://codereview.chromium.org/868893004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/868893004/diff/1/build/common.gypi#newcode398 build/common.gypi:398: 'asan_coverage%': 0, # deprecated please document how ...
5 years, 11 months ago (2015-01-23 13:51:04 UTC) #3
Alexander Potapenko
TBRing Jochen as one of the build/ and content/ owners.
5 years, 10 months ago (2015-02-13 16:11:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868893004/20001
5 years, 10 months ago (2015-02-13 16:13:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/42624)
5 years, 10 months ago (2015-02-13 16:18:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868893004/20001
5 years, 10 months ago (2015-02-13 16:23:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 18:01:59 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 18:02:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddea13be3be19fd889fb5953470faf154836e973
Cr-Commit-Position: refs/heads/master@{#316241}

Powered by Google App Engine
This is Rietveld 408576698