Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 868883003: Update {virtual,override,final} to follow C++11 style in printing, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in printing, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/374e914e95164d69df77dc6006a08dcd8734eed6 Cr-Commit-Position: refs/heads/master@{#312724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M printing/backend/print_backend_chromeos.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +17 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:35:44 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-22 22:49:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868883003/1
5 years, 11 months ago (2015-01-22 22:59:01 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:04:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868883003/1
5 years, 11 months ago (2015-01-23 01:06:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 01:17:38 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:19:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/374e914e95164d69df77dc6006a08dcd8734eed6
Cr-Commit-Position: refs/heads/master@{#312724}

Powered by Google App Engine
This is Rietveld 408576698