test/unittests/test-utils.h - Issue 868883002: Remove the dependency of Zone on Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/test-utils.h

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: All platforms Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/test-utils.h

diff --git a/test/unittests/test-utils.h b/test/unittests/test-utils.h

index 511e3574c869ba064c207476ac5e3b679f16a4a4..838b05c880381eaa78d1de6bf1c45e0e53f8d239 100644

--- a/test/unittests/test-utils.h

+++ b/test/unittests/test-utils.h

@@ -92,7 +92,7 @@ class TestWithIsolate : public virtual ::v8::TestWithIsolate {

class TestWithZone : public TestWithIsolate {

public:

- TestWithZone() : zone_(isolate()) {}

+ TestWithZone() : zone_() {}

Michael Starzinger 2015/01/23 14:21:11 nit: Explicit initializer call shouldn't be needed

danno 2015/01/23 14:45:21 Done.

virtual ~TestWithZone();

Zone* zone() { return &zone_; }