Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: test/cctest/compiler/graph-builder-tester.h

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: All platforms Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/graph-builder-tester.h
diff --git a/test/cctest/compiler/graph-builder-tester.h b/test/cctest/compiler/graph-builder-tester.h
index 772de4d11c366f991096211416a4413c7dfb6f06..c15dae8b4a7d65948e88d1314aef603b03fa8efe 100644
--- a/test/cctest/compiler/graph-builder-tester.h
+++ b/test/cctest/compiler/graph-builder-tester.h
@@ -22,7 +22,8 @@ namespace compiler {
// A class that just passes node creation on to the Graph.
class DirectGraphBuilder : public GraphBuilder {
public:
- explicit DirectGraphBuilder(Graph* graph) : GraphBuilder(graph) {}
+ explicit DirectGraphBuilder(Isolate* isolate, Graph* graph)
Michael Starzinger 2015/01/23 14:21:11 nit: No longer needs to be marked "explicit".
danno 2015/01/23 14:45:21 Done.
+ : GraphBuilder(isolate, graph) {}
virtual ~DirectGraphBuilder() {}
protected:
@@ -35,7 +36,7 @@ class DirectGraphBuilder : public GraphBuilder {
class MachineCallHelper : public CallHelper {
public:
- MachineCallHelper(Zone* zone, MachineSignature* machine_sig);
+ MachineCallHelper(Isolate* isolate, MachineSignature* machine_sig);
Node* Parameter(size_t index);
@@ -51,6 +52,7 @@ class MachineCallHelper : public CallHelper {
private:
Node** parameters_;
// TODO(dcarney): shouldn't need graph stored.
+ Isolate* isolate_;
Graph* graph_;
MaybeHandle<Code> code_;
};
@@ -88,12 +90,12 @@ class GraphBuilderTester
MachineType p4 = kMachNone)
: GraphAndBuilders(main_zone()),
MachineCallHelper(
- main_zone(),
+ main_isolate(),
MakeMachineSignature(
main_zone(), ReturnValueTraits<ReturnType>::Representation(),
p0, p1, p2, p3, p4)),
- SimplifiedGraphBuilder(main_graph_, &main_common_, &main_machine_,
- &main_simplified_) {
+ SimplifiedGraphBuilder(main_isolate(), main_graph_, &main_common_,
+ &main_machine_, &main_simplified_) {
Begin(static_cast<int>(parameter_count()));
InitParameters(this, &main_common_);
}

Powered by Google App Engine
This is Rietveld 408576698