Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/regexp-macro-assembler.h

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: All platforms Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp-macro-assembler.h
diff --git a/src/regexp-macro-assembler.h b/src/regexp-macro-assembler.h
index c2f8f4297fda571dcbc9ecbd6c7699ce00973936..b6683326b3bd126ffe0cc24047eda5f57b18d2a7 100644
--- a/src/regexp-macro-assembler.h
+++ b/src/regexp-macro-assembler.h
@@ -43,7 +43,7 @@ class RegExpMacroAssembler {
kCheckStackLimit = true
};
- explicit RegExpMacroAssembler(Zone* zone);
+ explicit RegExpMacroAssembler(Isolate* isolate, Zone* zone);
Michael Starzinger 2015/01/23 14:21:11 nit: No longer needs to be marked "explicit".
danno 2015/01/23 14:45:20 Done.
virtual ~RegExpMacroAssembler();
// The maximal number of pushes between stack checks. Users must supply
// kCheckStackLimit flag to push operations (instead of kNoStackLimitCheck)
@@ -158,11 +158,13 @@ class RegExpMacroAssembler {
return global_mode_ == GLOBAL;
}
+ Isolate* isolate() const { return isolate_; }
Zone* zone() const { return zone_; }
private:
bool slow_safe_compiler_;
bool global_mode_;
+ Isolate* isolate_;
Zone* zone_;
};
@@ -185,7 +187,7 @@ class NativeRegExpMacroAssembler: public RegExpMacroAssembler {
// capture positions.
enum Result { RETRY = -2, EXCEPTION = -1, FAILURE = 0, SUCCESS = 1 };
- explicit NativeRegExpMacroAssembler(Zone* zone);
+ explicit NativeRegExpMacroAssembler(Isolate* isolate, Zone* zone);
Michael Starzinger 2015/01/23 14:21:11 nit: No longer needs to be marked "explicit".
danno 2015/01/23 14:45:20 Done.
virtual ~NativeRegExpMacroAssembler();
virtual bool CanReadUnaligned();

Powered by Google App Engine
This is Rietveld 408576698