Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: src/ast.h

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: All platforms Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index a797272cec2d42432c94e6a7f09ad02c64a9a0f8..051cda13044a6920c68f85dcad254936a24703b8 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -3143,20 +3143,22 @@ class AstVisitor BASE_EMBEDDED {
\
bool CheckStackOverflow() { \
if (stack_overflow_) return true; \
- StackLimitCheck check(zone_->isolate()); \
+ StackLimitCheck check(isolate_); \
if (!check.HasOverflowed()) return false; \
stack_overflow_ = true; \
return true; \
} \
\
private: \
- void InitializeAstVisitor(Zone* zone) { \
+ void InitializeAstVisitor(Isolate* isolate, Zone* zone) { \
+ isolate_ = isolate; \
zone_ = zone; \
stack_overflow_ = false; \
} \
Zone* zone() { return zone_; } \
- Isolate* isolate() { return zone_->isolate(); } \
+ Isolate* isolate() { return isolate_; } \
\
+ Isolate* isolate_; \
Zone* zone_; \
bool stack_overflow_
@@ -3166,7 +3168,7 @@ class AstVisitor BASE_EMBEDDED {
class AstNodeFactory FINAL BASE_EMBEDDED {
public:
- explicit AstNodeFactory(AstValueFactory* ast_value_factory)
+ explicit AstNodeFactory(Isolate* isolate, AstValueFactory* ast_value_factory)
Michael Starzinger 2015/01/23 14:21:10 nit: The AstNodeFactory doesn't seem to use the Is
danno 2015/01/23 14:45:19 Done.
: zone_(ast_value_factory->zone()),
ast_value_factory_(ast_value_factory) {}
« no previous file with comments | « src/arm64/regexp-macro-assembler-arm64.cc ('k') | src/ast-numbering.h » ('j') | src/compiler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698