Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 868843003: SkAtomics: add asserts for valid memory orders. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : std too #

Patch Set 3 : names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M include/ports/SkAtomics_atomic.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M include/ports/SkAtomics_std.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
Should be an easy one. Just want to make sure we're enforcing the constraints of ...
5 years, 10 months ago (2015-02-09 21:46:06 UTC) #2
bungeman-skia
lgtm
5 years, 10 months ago (2015-02-09 21:51:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868843003/40001
5 years, 10 months ago (2015-02-09 21:57:19 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:13:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/01f797fcb0c7497d3d62af84516f489c83cd1634

Powered by Google App Engine
This is Rietveld 408576698