Issue 868843003: SkAtomics: add asserts for valid memory orders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 868843003: SkAtomics: add asserts for valid memory orders. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
bungeman-skia, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	include/ports/SkAtomics_atomic.h	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download
	M	include/ports/SkAtomics_std.h	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

mtklein_C

Should be an easy one. Just want to make sure we're enforcing the constraints of ...

5 years, 10 months ago (2015-02-09 21:46:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868843003/40001

5 years, 10 months ago (2015-02-09 21:57:19 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 22:13:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/01f797fcb0c7497d3d62af84516f489c83cd1634