Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 868823002: Expose double-tap platform support via ui::GestureConfiguration (Closed)

Created:
5 years, 11 months ago by jdduke (slow)
Modified:
5 years, 11 months ago
Reviewers:
tdresser
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose double-tap platform support via ui::GestureConfiguration Propagate platform support for double-tap gestures from ui::GestureConfiguration to GestureProvider::Config, ensuring consistent platform-specific double-tap behavior. BUG=425586, 325506 Committed: https://crrev.com/d823c1b21de57472e1bd52f7a3d9c7c23239b3b9 Cr-Commit-Position: refs/heads/master@{#312725}

Patch Set 1 #

Patch Set 2 : Fix propagation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M ui/events/gesture_detection/gesture_configuration.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_configuration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_configuration_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_configuration_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider_config_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jdduke (slow)
tdresser@: PTAL, thanks.
5 years, 11 months ago (2015-01-22 19:50:15 UTC) #2
tdresser
On 2015/01/22 19:50:15, jdduke wrote: > tdresser@: PTAL, thanks. We should probably add some tests ...
5 years, 11 months ago (2015-01-22 20:24:19 UTC) #3
jdduke (slow)
On 2015/01/22 20:24:19, tdresser wrote: > On 2015/01/22 19:50:15, jdduke wrote: > > tdresser@: PTAL, ...
5 years, 11 months ago (2015-01-22 20:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868823002/20001
5 years, 11 months ago (2015-01-22 20:26:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/113928)
5 years, 11 months ago (2015-01-23 00:48:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868823002/20001
5 years, 11 months ago (2015-01-23 00:57:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 01:18:30 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:19:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d823c1b21de57472e1bd52f7a3d9c7c23239b3b9
Cr-Commit-Position: refs/heads/master@{#312725}

Powered by Google App Engine
This is Rietveld 408576698