Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 868803008: Merge 188423 into M41 branch 2272: "Fix handling of broken GIFs with weird frame sizes" (Closed)

Created:
5 years, 10 months ago by pennymac
Modified:
5 years, 10 months ago
Reviewers:
Alpha Left Google
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Merge 188423 into M41 branch 2272: "Fix handling of broken GIFs with weird frame sizes" > Fix handling of broken GIFs with weird frame sizes > > Code didn't handle well if a GIF frame has dimension greater than the > "screen" dimension. This will break deferred image decoding. > > This change reports the size as final only when the first frame is > encountered. > > Added a test to verify this behavior. Frame size reported by the decoder > should be constant. > > BUG=437651 > R=pkasting@chromium.org, senorblanco@chromium.org > > Review URL: https://codereview.chromium.org/813943003 TBR=hclam@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -57 lines) Patch
M Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 19 chunks +58 lines, -27 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageReader.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageReader.cpp View 3 chunks +33 lines, -31 lines 0 comments Download
A + Source/platform/image-decoders/testing/first-frame-has-greater-size-than-screen-size.gif View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pennymac
5 years, 10 months ago (2015-01-29 02:29:26 UTC) #1
pennymac
5 years, 10 months ago (2015-01-29 02:29:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r189154.

Powered by Google App Engine
This is Rietveld 408576698