Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2415)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 868803002: cc: Change the activation/ready for draw check from layer to queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 5299d701430a0e83597a44ba09844a450c3094ee..ab1224ef1f9a28ba9193145db3f7db77a852633a 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -96,12 +96,8 @@ class LayerTreeHostTestReadyToActivateEmpty : public LayerTreeHostTest {
void NotifyReadyToActivateOnThread(LayerTreeHostImpl* impl) override {
did_notify_ready_to_activate_ = true;
- const std::vector<PictureLayerImpl*>& layers = impl->GetPictureLayers();
- all_tiles_required_for_activation_are_ready_to_draw_ = true;
- for (const auto& layer : layers) {
- if (!layer->AllTilesRequiredForActivationAreReadyToDraw())
- all_tiles_required_for_activation_are_ready_to_draw_ = false;
- }
+ all_tiles_required_for_activation_are_ready_to_draw_ =
+ impl->tile_manager()->IsReadyToActivate();
EndTest();
}
@@ -161,10 +157,9 @@ class LayerTreeHostTestReadyToDrawEmpty : public LayerTreeHostTest {
void NotifyReadyToDrawOnThread(LayerTreeHostImpl* impl) override {
did_notify_ready_to_draw_ = true;
const std::vector<PictureLayerImpl*>& layers = impl->GetPictureLayers();
- all_tiles_required_for_draw_are_ready_to_draw_ = true;
+ all_tiles_required_for_draw_are_ready_to_draw_ =
+ impl->tile_manager()->IsReadyToDraw();
for (const auto& layer : layers) {
- if (!layer->AllTilesRequiredForDrawAreReadyToDraw())
- all_tiles_required_for_draw_are_ready_to_draw_ = false;
FakePictureLayerImpl* fake_layer =
static_cast<FakePictureLayerImpl*>(layer);
required_for_draw_count_ += fake_layer->CountTilesRequiredForDraw();
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698