Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868783002: remove unnecessary guard flags for android (for conics) (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unnecessary guard flags for android (for conics) BUG=skia: NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/5c05a1b1375301e02ecc3bf2bb5c1b851239bb5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
Should be a no-op assuming HWUI doesn't ever directly parse paths into segments...
5 years, 11 months ago (2015-01-22 18:40:19 UTC) #2
scroggo
lgtm
5 years, 11 months ago (2015-01-22 19:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868783002/1
5 years, 11 months ago (2015-01-22 19:45:03 UTC) #5
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
5 years, 11 months ago (2015-01-22 21:25:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868783002/1
5 years, 11 months ago (2015-01-22 21:29:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868783002/1
5 years, 11 months ago (2015-01-22 21:40:52 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 21:41:03 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5c05a1b1375301e02ecc3bf2bb5c1b851239bb5c

Powered by Google App Engine
This is Rietveld 408576698