Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 868753007: Change GetCanonicalSuffix() interface. (Closed)

Created:
5 years, 10 months ago by Bence
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GetCanonicalSuffix() interface. This CL changes the argument of GetCanonicalSuffix() from HostPortPair to std::string (both const&) to better document the fact that GetCanonicalSuffix only operates on that field. BUG=392575 Committed: https://crrev.com/c45e09b004eb4fe3f317052c072f6173c1e6986c Cr-Commit-Position: refs/heads/master@{#314014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M net/http/http_server_properties_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thank you.
5 years, 10 months ago (2015-01-30 19:50:51 UTC) #2
Ryan Hamilton
lgtm Nice catch.
5 years, 10 months ago (2015-01-30 21:33:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868753007/1
5 years, 10 months ago (2015-01-30 21:51:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 22:45:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 22:46:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c45e09b004eb4fe3f317052c072f6173c1e6986c
Cr-Commit-Position: refs/heads/master@{#314014}

Powered by Google App Engine
This is Rietveld 408576698