Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 868753006: Revert of Manage profiles in BluetoothAdapter on ChromeOS (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Manage profiles in BluetoothAdapter on ChromeOS (patchset #5 id:80001 of https://codereview.chromium.org/851123002/) Reason for revert: This causes a leak on Chrome Os ASan. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6306/steps/device_unittests/logs/Connect Original issue's description: > Manage profiles in BluetoothAdapter on ChromeOS > > Profiles in bluez are not specific to a device. > When client code tries to connect to two different devices, only > one profile is created, managed by BluetoothAdapterChromeOS. > > dbus messages are multiplexed based on the device desired using new > class BluetoothAdapterProfileChromeOS. > > BUG=chromium:421207 > > Committed: https://crrev.com/c56186ac2901c99349cbb4b4a6b8aa0ff8088c4d > Cr-Commit-Position: refs/heads/master@{#313837} TBR=armansito@chromium.org,keybuk@chromium.org,rpaquay@chromium.org,jamuraa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:421207 Committed: https://crrev.com/2071df6e26f1d038b7741967168bfcf8bd64edf8 Cr-Commit-Position: refs/heads/master@{#313883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -858 lines) Patch
M chromeos/dbus/fake_bluetooth_profile_manager_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_service_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 7 chunks +0 lines, -45 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 2 chunks +0 lines, -71 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos.h View 1 chunk +0 lines, -101 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc View 1 chunk +0 lines, -297 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.h View 6 chunks +22 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.cc View 17 chunks +157 lines, -127 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 13 chunks +5 lines, -24 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
perkj_chrome
Created Revert of Manage profiles in BluetoothAdapter on ChromeOS
5 years, 10 months ago (2015-01-30 08:32:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868753006/1
5 years, 10 months ago (2015-01-30 08:33:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 08:34:27 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 08:35:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2071df6e26f1d038b7741967168bfcf8bd64edf8
Cr-Commit-Position: refs/heads/master@{#313883}

Powered by Google App Engine
This is Rietveld 408576698