Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 868753005: Enable Roboto by default for testing purpose. (Closed)

Created:
5 years, 11 months ago by xdai1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Roboto by default for testing purpose. The testing team wants to enable 'Roboto' by default and have real users to help report bugs too. In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on. Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice). BUG=448948 TEST=tested on device (Pixel) Committed: https://crrev.com/b138032ecd37b1225ac200f561d6232d423dd89a Cr-Commit-Position: refs/heads/master@{#313628}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Address isherman@'s comment. #

Patch Set 3 : #

Patch Set 4 : Modify OobeWebUi test to run in fullscreen. #

Patch Set 5 : Modify the test TextDoesntClip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/chromeos/oobe_webui_browsertest.js View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/font_helper_chromeos.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/font_helper_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
xdai1
Please help to review the CL, thanks! jshin: all avi: ui/base isherman: tools/metrics
5 years, 11 months ago (2015-01-22 23:39:37 UTC) #3
Ilya Sherman
LGTM with my comment addressed: https://codereview.chromium.org/868753005/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/868753005/diff/20001/tools/metrics/histograms/histograms.xml#oldcode50436 tools/metrics/histograms/histograms.xml:50436: - <int value="598827460" label="enable-roboto-font-ui"/> ...
5 years, 11 months ago (2015-01-22 23:48:53 UTC) #4
xdai1
On 2015/01/22 23:48:53, Ilya Sherman wrote: > LGTM with my comment addressed: > > https://codereview.chromium.org/868753005/diff/20001/tools/metrics/histograms/histograms.xml ...
5 years, 11 months ago (2015-01-23 00:06:27 UTC) #5
jungshik at Google
LGTM
5 years, 11 months ago (2015-01-23 22:59:51 UTC) #6
xdai1
brettw@, can you help to review this CL please? Thanks!
5 years, 10 months ago (2015-01-26 23:41:39 UTC) #8
xdai1
sadrul@, can you help to review this cl please? Thanks!
5 years, 10 months ago (2015-01-27 22:36:12 UTC) #10
sadrul
lgtm
5 years, 10 months ago (2015-01-27 23:49:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868753005/40001
5 years, 10 months ago (2015-01-27 23:52:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18918)
5 years, 10 months ago (2015-01-28 01:01:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868753005/80001
5 years, 10 months ago (2015-01-28 21:59:54 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-01-29 00:03:06 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b138032ecd37b1225ac200f561d6232d423dd89a Cr-Commit-Position: refs/heads/master@{#313628}
5 years, 10 months ago (2015-01-29 00:04:45 UTC) #19
perkj_chrome
5 years, 10 months ago (2015-01-29 09:36:10 UTC) #20
Message was sent while issue was closed.
On 2015/01/29 00:04:45, I haz the power (commit-bot) wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/b138032ecd37b1225ac200f561d6232d423dd89a
> Cr-Commit-Position: refs/heads/master@{#313628}
This seems to make RenderTextTest.TextDoesntClip to fail on Chrome OS Asan
/Lsan.
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

This cl have been reverted in https://codereview.chromium.org/889533002/

Powered by Google App Engine
This is Rietveld 408576698