Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 868693002: Calculate new version based on latest tag when pushing. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Calculate new version based on latest tag when pushing. BUG=chromium:451357 TBR=tandrii@chromium.org LOG=n NOTRY=true Committed: https://crrev.com/8a67083705c45ef7c06f0a79dd5f2369b2823cc9 Cr-Commit-Position: refs/heads/master@{#26243}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -58 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 4 chunks +24 lines, -38 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 3 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-22 14:41:08 UTC) #2
tandrii(chromium)
lgtm
5 years, 11 months ago (2015-01-22 15:00:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868693002/20001
5 years, 11 months ago (2015-01-23 10:18:18 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-23 10:18:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868693002/20001
5 years, 11 months ago (2015-01-23 10:30:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 10:30:40 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 10:31:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a67083705c45ef7c06f0a79dd5f2369b2823cc9
Cr-Commit-Position: refs/heads/master@{#26243}

Powered by Google App Engine
This is Rietveld 408576698