[WebView] Repack the .pak files for all the locales.

android_webview/android_webview_locales_rename_paks.gypi

Index: android_webview/android_webview_locales_rename_paks.gypi
diff --git a/android_webview/android_webview_locales_rename_paks.gypi b/android_webview/android_webview_locales_rename_paks.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..32c4eb46eb4c43d15adcd3817bf36ea37962173b
--- /dev/null
+++ b/android_webview/android_webview_locales_rename_paks.gypi
@@ -0,0 +1,25 @@
+# Copyright (c) 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# To use this the following variables need to be defined:
+#   pak_locales: string: the list of all the locales that need renaming and moving
+{
+  'variables': {
+    'rename_locales': 'tools/webview_locales_rename_paks.py',
+  },
+  'inputs': [
+    '<(rename_locales)',
+    '<!@pymod_do_main(webview_locales_rename_paks -i -p <(PRODUCT_DIR) -s <(SHARED_INTERMEDIATE_DIR) <(pak_locales))'

[cjhopman, 2015/01/28 00:37:44]

Calling out to a script to determine inputs/outputs is a pattern that we really
want to avoid.

I think that you could probably do this renaming with gyp rule and build/cp.py.

You could do this:

have android_locales_paks.gypi with the inputs pointing to the unrenamed ones in
<(PRODUCT_DIR)/content/app/strings and the outputs be based on a variable that
is different for webview/chrome. Then have a gypi that contains a rule to do the
copying renaming from those inputs to outputs.

[Ignacio Solla, 2015/02/02 17:11:32]

While building the apks there are two separate operations that need to be
performed at different levels:
1. Generate the <locale>.pak files
2. Move the <locale>.pak files across folders

Step 1 is different in the WebView and Chrome. The WebView only needs to rename
the content_strings_<locale>.paks to generate the <locale>.paks. Chrome repacks
several paks together (including the content_strings_<locale>.pak) to generate
each <locale>.pak (see repack_locales.py).

The purpose of the android_locales_paks.gypi is to help with step 2 so we cannot
rename the input files to content_strings_<locale>.pak. As such, I prefer to
generate the list of inputs with a script given the list of pak_locales instead
of having yet another explicit list of files. However, if you feel strongly
about it I'd be willing to change it.

If we use a gypi with a rule we still need to create our own python script and
we cannot use build/cp.py directly. build/cp.py expects the destination
filename, but we can only construct this in our own script given
RULE_INPUT_ROOT. So having a rule instead of an action does not buy us much
because we still need our own custom python script.

+  ],
+  'outputs': [
+    '<!@pymod_do_main(webview_locales_rename_paks -o -p <(PRODUCT_DIR) -s <(SHARED_INTERMEDIATE_DIR) <(pak_locales))'
+  ],
+  'action': [
+    'python',
+    '<(rename_locales)',
+    '-p', '<(PRODUCT_DIR)',
+    '-s', '<(SHARED_INTERMEDIATE_DIR)',
+    '<@(pak_locales)',
+  ],
+}