Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3086)

Unified Diff: android_webview/android_webview.gyp

Issue 868673003: [WebView] Repack the .pak files for all the locales. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix AOSP bot Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/android_webview.gyp
diff --git a/android_webview/android_webview.gyp b/android_webview/android_webview.gyp
index 4018c9f2c55d58823381c1a86b318e3fae4e7a02..34dcac0180a9b3a0c41a44677c368ab1b2414859 100644
--- a/android_webview/android_webview.gyp
+++ b/android_webview/android_webview.gyp
@@ -31,12 +31,11 @@
'includes': [ '../build/repack_action.gypi' ],
},
{
- 'action_name': 'add_en_US_pak_locale',
+ 'action_name': 'android_webview_locales_rename_paks',
'variables': {
- 'pak_inputs': ['<(SHARED_INTERMEDIATE_DIR)/content/app/strings/content_strings_en-US.pak'],
- 'pak_output': '<(PRODUCT_DIR)/android_webview_assets/en-US.pak',
+ 'pak_locales': '<(locales)',
},
- 'includes': [ '../build/repack_action.gypi' ],
+ 'includes': [ 'android_webview_locales_rename_paks.gypi' ],
}
],
},
@@ -122,7 +121,6 @@
'../ui/shell_dialogs/shell_dialogs.gyp:shell_dialogs',
'../v8/tools/gyp/v8.gyp:v8',
'../webkit/common/gpu/webkit_gpu.gyp:webkit_gpu',
- 'android_webview_pak',
'android_webview_version',
],
'include_dirs': [
@@ -267,6 +265,11 @@
'renderer/print_render_frame_observer.cc',
'renderer/print_render_frame_observer.h',
],
+ 'conditions': [
+ ['android_webview_build==0', {
+ 'dependencies': [ 'android_webview_pak', ],
+ }],
+ ],
},
{
'target_name': 'libwebviewchromium',

Powered by Google App Engine
This is Rietveld 408576698