[WebView] Repack the .pak files for all the locales.

[WebView] Pack the .pak files for all the locales.

This changes includes all the locale .pak files into the
WebView apk when building it from the chromium tree,
similarly to what we're doing when building it from the
Android tree, see android_webview/Android.mk.

BUG=405035
TESTED=Manual. Verified that the set of locales in the
downstream and upstream SystemWebViewGoogle.apk is the same.

Committed: https://crrev.com/0826b636a11190f231e2ca167f7ec1304234be6a
Cr-Commit-Position: refs/heads/master@{#315001}

[Ignacio Solla, 2015-01-22 16:44:24]

igsolla@chromium.org changed reviewers:
+ mkosiba@chromium.org, torne@chromium.org

[Ignacio Solla, 2015-01-22 16:44:24]

torne@chromium.org: Please review all changes 

mkosiba@chromium.org: Please review all changes

[Ignacio Solla, 2015-01-22 16:46:31]

On 2015/01/22 16:44:24, Ignacio Solla wrote:
> mailto:torne@chromium.org: Please review all changes 
> 
> mailto:mkosiba@chromium.org: Please review all changes

Sorry I've just realized that I'm missing the copies.

[Ignacio Solla, 2015-01-26 19:46:47]

igsolla@chromium.org changed reviewers:
+ cjhopman@chromium.org, kkimlabs@chromium.org

[Ignacio Solla, 2015-01-26 19:55:17]

On 2015/01/22 16:46:31, Ignacio Solla wrote:
> On 2015/01/22 16:44:24, Ignacio Solla wrote:
> > mailto:torne@chromium.org: Please review all changes 
> > 
> > mailto:mkosiba@chromium.org: Please review all changes
> 
> Sorry I've just realized that I'm missing the copies.

hello all, could you take a look and let me know if the overall approach makes
sense?

If so I'll spend more time verifying that everything still works, and double
checking that all the required places have been updated. I will also need to
land a downstream change to Clank (ie. 193518).

Thanks!

[mkosiba (inactive), 2015-01-27 10:26:15]

lgtm

https://codereview.chromium.org/868673003/diff/20001/android_webview/tools/we...
File android_webview/tools/webview_locales_rename_paks.py (right):

https://codereview.chromium.org/868673003/diff/20001/android_webview/tools/we...
android_webview/tools/webview_locales_rename_paks.py:19: return
os.path.join(PRODUCT_DIR, 'android_webview_assets', locale + '.pak')
maybe let's have a separate folder just for the locale .pak files?

[cjhopman, 2015-01-28 00:37:44]

https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
File android_webview/android_webview_locales_rename_paks.gypi (right):

https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
android_webview/android_webview_locales_rename_paks.gypi:13:
'<!@pymod_do_main(webview_locales_rename_paks -i -p <(PRODUCT_DIR) -s
<(SHARED_INTERMEDIATE_DIR) <(pak_locales))'
Calling out to a script to determine inputs/outputs is a pattern that we really
want to avoid.

I think that you could probably do this renaming with gyp rule and build/cp.py.

You could do this:

have android_locales_paks.gypi with the inputs pointing to the unrenamed ones in
<(PRODUCT_DIR)/content/app/strings and the outputs be based on a variable that
is different for webview/chrome. Then have a gypi that contains a rule to do the
copying renaming from those inputs to outputs.

[Ignacio Solla, 2015-02-02 17:11:32]

https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
File android_webview/android_webview_locales_rename_paks.gypi (right):

https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
android_webview/android_webview_locales_rename_paks.gypi:13:
'<!@pymod_do_main(webview_locales_rename_paks -i -p <(PRODUCT_DIR) -s
<(SHARED_INTERMEDIATE_DIR) <(pak_locales))'
On 2015/01/28 00:37:44, cjhopman wrote:
> Calling out to a script to determine inputs/outputs is a pattern that we
really
> want to avoid.
> 
> I think that you could probably do this renaming with gyp rule and
build/cp.py.
> 
> You could do this:
> 
> have android_locales_paks.gypi with the inputs pointing to the unrenamed ones
in
> <(PRODUCT_DIR)/content/app/strings and the outputs be based on a variable that
> is different for webview/chrome. Then have a gypi that contains a rule to do
the
> copying renaming from those inputs to outputs.

While building the apks there are two separate operations that need to be
performed at different levels:
1. Generate the <locale>.pak files
2. Move the <locale>.pak files across folders

Step 1 is different in the WebView and Chrome. The WebView only needs to rename
the content_strings_<locale>.paks to generate the <locale>.paks. Chrome repacks
several paks together (including the content_strings_<locale>.pak) to generate
each <locale>.pak (see repack_locales.py).

The purpose of the android_locales_paks.gypi is to help with step 2 so we cannot
rename the input files to content_strings_<locale>.pak. As such, I prefer to
generate the list of inputs with a script given the list of pak_locales instead
of having yet another explicit list of files. However, if you feel strongly
about it I'd be willing to change it.

If we use a gypi with a rule we still need to create our own python script and
we cannot use build/cp.py directly. build/cp.py expects the destination
filename, but we can only construct this in our own script given
RULE_INPUT_ROOT. So having a rule instead of an action does not buy us much
because we still need our own custom python script.

[Ignacio Solla, 2015-02-02 17:53:58]

https://codereview.chromium.org/868673003/diff/20001/android_webview/tools/we...
File android_webview/tools/webview_locales_rename_paks.py (right):

https://codereview.chromium.org/868673003/diff/20001/android_webview/tools/we...
android_webview/tools/webview_locales_rename_paks.py:19: return
os.path.join(PRODUCT_DIR, 'android_webview_assets', locale + '.pak')
On 2015/01/27 10:26:15, mkosiba (inactive) wrote:
> maybe let's have a separate folder just for the locale .pak files?

Done.

[cjhopman, 2015-02-02 18:42:41]

On 2015/02/02 17:11:32, Ignacio Solla wrote:
>
https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
> File android_webview/android_webview_locales_rename_paks.gypi (right):
> 
>
https://codereview.chromium.org/868673003/diff/20001/android_webview/android_...
> android_webview/android_webview_locales_rename_paks.gypi:13:
> '<!@pymod_do_main(webview_locales_rename_paks -i -p <(PRODUCT_DIR) -s
> <(SHARED_INTERMEDIATE_DIR) <(pak_locales))'
> On 2015/01/28 00:37:44, cjhopman wrote:
> > Calling out to a script to determine inputs/outputs is a pattern that we
> really
> > want to avoid.
> > 
> > I think that you could probably do this renaming with gyp rule and
> build/cp.py.
> > 
> > You could do this:
> > 
> > have android_locales_paks.gypi with the inputs pointing to the unrenamed
ones
> in
> > <(PRODUCT_DIR)/content/app/strings and the outputs be based on a variable
that
> > is different for webview/chrome. Then have a gypi that contains a rule to do
> the
> > copying renaming from those inputs to outputs.
> 
> While building the apks there are two separate operations that need to be
> performed at different levels:
> 1. Generate the <locale>.pak files
> 2. Move the <locale>.pak files across folders
> 
> Step 1 is different in the WebView and Chrome. The WebView only needs to
rename
> the content_strings_<locale>.paks to generate the <locale>.paks. Chrome
repacks
> several paks together (including the content_strings_<locale>.pak) to generate
> each <locale>.pak (see repack_locales.py).
> 
> The purpose of the android_locales_paks.gypi is to help with step 2 so we
cannot
> rename the input files to content_strings_<locale>.pak. As such, I prefer to
> generate the list of inputs with a script given the list of pak_locales
instead
> of having yet another explicit list of files. However, if you feel strongly
> about it I'd be willing to change it.
> 
> If we use a gypi with a rule we still need to create our own python script and
> we cannot use build/cp.py directly. build/cp.py expects the destination
> filename, but we can only construct this in our own script given
> RULE_INPUT_ROOT. So having a rule instead of an action does not buy us much
> because we still need our own custom python script.

lgtm. This approach seems to be the same as what we do for other stuff (w/
repack_locales.py and friends).

[Torne, 2015-02-05 17:16:24]

LGTM with one suggestion:

https://codereview.chromium.org/868673003/diff/100001/android_webview/android...
File android_webview/android_webview_locales_rename_paks.gypi (right):

https://codereview.chromium.org/868673003/diff/100001/android_webview/android...
android_webview/android_webview_locales_rename_paks.gypi:1: # Copyright (c) 2015
The Chromium Authors. All rights reserved.
Since this file is pretty short and only used once it's probably easier to just
inline it into android_webview.gyp.

[Ignacio Solla, 2015-02-05 18:58:00]

New patchsets have been uploaded after l-g-t-m from torne@chromium.org

[Ignacio Solla, 2015-02-05 18:58:46]

https://codereview.chromium.org/868673003/diff/100001/android_webview/android...
File android_webview/android_webview_locales_rename_paks.gypi (right):

https://codereview.chromium.org/868673003/diff/100001/android_webview/android...
android_webview/android_webview_locales_rename_paks.gypi:1: # Copyright (c) 2015
The Chromium Authors. All rights reserved.
On 2015/02/05 17:16:24, Torne wrote:
> Since this file is pretty short and only used once it's probably easier to
just
> inline it into android_webview.gyp.

Done.

[Ignacio Solla, 2015-02-05 18:58:51]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2015-02-05 19:00:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868673003/120001

[commit-bot: I haz the power, 2015-02-05 21:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 21:06:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ignacio Solla, 2015-02-06 09:46:58]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2015-02-06 09:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868673003/120001

[commit-bot: I haz the power, 2015-02-06 12:10:39]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-02-06 12:12:07]

Patchset 7 (id:??) landed as
https://crrev.com/0826b636a11190f231e2ca167f7ec1304234be6a
Cr-Commit-Position: refs/heads/master@{#315001}