content/browser/devtools/render_view_devtools_agent_host.h - Issue 868673002: OOPIF: report both original and destination rfh in AboutToNavigateRenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.h

Issue 868673002: OOPIF: report both original and destination rfh in AboutToNavigateRenderFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_view_devtools_agent_host.h

diff --git a/content/browser/devtools/render_view_devtools_agent_host.h b/content/browser/devtools/render_view_devtools_agent_host.h

index af182b2a459733d65d89fec4ffe7ccd750f7c1b7..dd509dcf91e2adea93a1433950f291bceed04b40 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.h

+++ b/content/browser/devtools/render_view_devtools_agent_host.h

@@ -52,6 +52,8 @@ class CONTENT_EXPORT RenderViewDevToolsAgentHost

void SynchronousSwapCompositorFrame(

const cc::CompositorFrameMetadata& frame_metadata);

+ bool HasRenderFrameHost(RenderFrameHost* host);

// DevTooolsAgentHost overrides.

void DisconnectWebContents() override;

void ConnectWebContents(WebContents* web_contents) override;

@@ -75,7 +77,8 @@ class CONTENT_EXPORT RenderViewDevToolsAgentHost

void OnClientDetached() override;

// WebContentsObserver overrides.

- void AboutToNavigateRenderFrame(RenderFrameHost* render_frame_host) override;

+ void AboutToNavigateRenderFrame(RenderFrameHost* old_host,

+ RenderFrameHost* new_host) override;

void RenderFrameHostChanged(RenderFrameHost* old_host,

RenderFrameHost* new_host) override;

void RenderFrameDeleted(RenderFrameHost* rvh) override;