chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 868673002: OOPIF: report both original and destination rfh in AboutToNavigateRenderFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 868673002: OOPIF: report both original and destination rfh in AboutToNavigateRenderFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index 3c3d433c045e7afb666be97f24af93ac025fddfc..9c6527358e51f98565a153e0c2fac7960c2871fc 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -55,7 +55,8 @@ class WebNavigationTabObserver

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

void RenderViewDeleted(content::RenderViewHost* render_view_host) override;

void AboutToNavigateRenderFrame(

- content::RenderFrameHost* render_frame_host) override;

+ content::RenderFrameHost* old_host,

+ content::RenderFrameHost* new_host) override;

void DidStartProvisionalLoadForFrame(

content::RenderFrameHost* render_frame_host,

const GURL& validated_url,