Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 868673002: OOPIF: report both original and destination rfh in AboutToNavigateRenderFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 36b277880b95d3761aaa2118567e490caf946260..a49333e39e8c6c205c5dc447b03bdb7b3b45f56c 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -249,7 +249,8 @@ class DevToolsUIBindings::FrontendWebContentsObserver
// TODO(creis): Replace with RenderFrameCreated when http://crbug.com/425397
// is fixed. See also http://crbug.com/424641.
void AboutToNavigateRenderFrame(
- content::RenderFrameHost* render_frame_host) override;
+ content::RenderFrameHost* render_frame_host,
dgozman 2015/01/22 13:54:08 Let's use |old_host| and |new_host| for consistenc
pfeldman 2015/01/22 22:10:04 Done.
+ content::RenderFrameHost* dest_frame_host) override;
void DocumentOnLoadCompletedInMainFrame() override;
void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
@@ -287,11 +288,12 @@ void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(
}
void DevToolsUIBindings::FrontendWebContentsObserver::
- AboutToNavigateRenderFrame(content::RenderFrameHost* render_frame_host) {
- if (render_frame_host->GetParent())
+ AboutToNavigateRenderFrame(content::RenderFrameHost* old_host,
+ content::RenderFrameHost* new_host) {
+ if (new_host->GetParent())
return;
devtools_bindings_->frontend_host_.reset(
- content::DevToolsFrontendHost::Create(render_frame_host,
+ content::DevToolsFrontendHost::Create(new_host,
devtools_bindings_));
}

Powered by Google App Engine
This is Rietveld 408576698