Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868663009: Add infobar layout for app install banners. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add infobar layout for app install banners. This makes InfoBarLayout more flexible and uses that flexibility to implement the app banner view. BUG=442690 Committed: https://crrev.com/eb815b6c390791b95cc6e1a823d038c6eea2166e Cr-Commit-Position: refs/heads/master@{#315195}

Patch Set 1 #

Patch Set 2 : removed local testing cruft #

Patch Set 3 : updated AppBannerInfoBar.java #

Total comments: 6

Patch Set 4 : works now #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -78 lines) Patch
A chrome/android/java/res/drawable-hdpi/google_play.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/star_gray.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/star_green.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/google_play.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/star_gray.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/star_green.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/google_play.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/star_gray.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/star_green.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/google_play.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/star_gray.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/star_green.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/google_play.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/star_gray.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/star_green.png View Binary file 0 comments Download
A chrome/android/java/res/drawable/rating_bar.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/app_banner_title.xml View 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/android/java/res/layout/infobar_text.xml View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java View 1 2 3 4 3 chunks +31 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java View 1 2 3 4 11 chunks +136 lines, -60 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ButtonCompat.java View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-02-07 01:51:10 UTC) #2
gone
lgtm, I can fix the nits when I land my CL on top of yours, ...
5 years, 10 months ago (2015-02-07 03:03:51 UTC) #3
newt (away)
https://chromiumcodereview.appspot.com/868663009/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java (right): https://chromiumcodereview.appspot.com/868663009/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java#newcode89 chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:89: ratingView.setRating(4.2f); On 2015/02/07 03:03:51, dfalcantara wrote: > nit: remove ...
5 years, 10 months ago (2015-02-07 03:11:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868663009/60001
5 years, 10 months ago (2015-02-07 03:13:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31814)
5 years, 10 months ago (2015-02-07 03:16:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868663009/60001
5 years, 10 months ago (2015-02-07 04:08:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/56512) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-07 04:11:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868663009/60001
5 years, 10 months ago (2015-02-07 04:20:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/21658) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-07 04:23:29 UTC) #17
gone
Something seems to be a bit off, layout wise: https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDSFRMVk5NLWlRYnc/view?usp=sharing
5 years, 10 months ago (2015-02-07 04:38:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/868663009/80001
5 years, 10 months ago (2015-02-07 08:51:37 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-07 12:32:18 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 12:32:53 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/eb815b6c390791b95cc6e1a823d038c6eea2166e
Cr-Commit-Position: refs/heads/master@{#315195}

Powered by Google App Engine
This is Rietveld 408576698